Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSRF_KEY in core-secret.yaml not passed as environment variable #1631

Closed
cvegagimenez opened this issue Oct 26, 2023 · 2 comments
Closed

CSRF_KEY in core-secret.yaml not passed as environment variable #1631

cvegagimenez opened this issue Oct 26, 2023 · 2 comments
Assignees

Comments

@cvegagimenez
Copy link
Contributor

cvegagimenez commented Oct 26, 2023

The CSRF_KEY is generated in the core-secret.yaml but it not passed to the core-dpl.yaml as environment variable.

        env:
          - name: CSRF_KEY
            valueFrom:
              secretKeyRef:
                name: {{ template "harbor.core" . }}
                key: CSRF_KEY

Also, this secret should allow to be passed from other secret to be generated with ExternalSecret.

@zyyw zyyw self-assigned this Nov 2, 2023
@zyyw
Copy link
Collaborator

zyyw commented Nov 2, 2023

this PR might resolves this issue:

@Kajot-dev
Copy link
Contributor

Well, it is passed because of envFrom (all keys from core secret are passed as env variables).
I made a PR that would prevent the value from regenerating every time though it's not reviewed: #1612

@zyyw zyyw closed this as completed Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants