-
Notifications
You must be signed in to change notification settings - Fork 762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix random values regenerating #1612
Conversation
Signed-off-by: jjaruszewski <[email protected]>
3871ffc
to
fb00e21
Compare
Signed-off-by: jjaruszewski <[email protected]>
Signed-off-by: jjaruszewski <[email protected]>
Signed-off-by: jjaruszewski <[email protected]>
Signed-off-by: jjaruszewski <[email protected]>
This reverts commit 778eab5. Signed-off-by: jjaruszewski <[email protected]>
@zyyw Reverted generating internal database password as this could possibly break existing installations and changes current behavior which allows empty password for internal database. |
@Kajot-dev congrats on your first PR merged here :)) welcome to the club! :) |
Seeing the same in ArgoCD. It's not clear to me why the checksum is changing as diffing the FWIW, I ended up just ignoring the checksum annotations in the ArgoCD app (you can be more tactical than this -- I'm lazy): ignoreDifferences:
- group: "*"
kind: Secret
jsonPointers:
- /data
- group: apps
kind: Deployment
jsonPointers:
- /spec/template/metadata/annotations |
I'm guessing that ArgoCD uses |
swift
andoss
Fixes: #1609 #1549
Essentially does the same thing as #1550 but with different approach