Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix random values regenerating #1612

Merged
merged 7 commits into from
Dec 13, 2023
Merged

Conversation

Kajot-dev
Copy link
Contributor

  • Fixes regeneration of random secrets
  • Adds support for existingSecret for swift and oss

Fixes: #1609 #1549

Essentially does the same thing as #1550 but with different approach

Signed-off-by: jjaruszewski <[email protected]>
@Kajot-dev
Copy link
Contributor Author

@zyyw Reverted generating internal database password as this could possibly break existing installations and changes current behavior which allows empty password for internal database.
Also resolved conflicts.

@ywk253100 ywk253100 merged commit 8a44c93 into goharbor:main Dec 13, 2023
6 checks passed
@OrlinVasilev
Copy link
Member

@Kajot-dev congrats on your first PR merged here :)) welcome to the club! :)

@kevin7s-io
Copy link

@OrlinVasilev,

Seeing the same in ArgoCD. It's not clear to me why the checksum is changing as diffing the {release}-harbor-core secret shows no differences between sync runs.

FWIW, I ended up just ignoring the checksum annotations in the ArgoCD app (you can be more tactical than this -- I'm lazy):

  ignoreDifferences:
    - group: "*"
      kind: Secret
      jsonPointers:
        - /data
    - group: apps
      kind: Deployment
      jsonPointers:
        - /spec/template/metadata/annotations

@Kajot-dev
Copy link
Contributor Author

I'm guessing that ArgoCD uses helm template? If so, the lookup helm function will not work and checksum will be different each time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: varying checksum
5 participants