Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE_SECRET can not be passed from external secret #1630

Closed
cvegagimenez opened this issue Oct 26, 2023 · 2 comments
Closed

CORE_SECRET can not be passed from external secret #1630

cvegagimenez opened this issue Oct 26, 2023 · 2 comments

Comments

@cvegagimenez
Copy link
Contributor

core-secret.yaml forces to pass the CORE_SECRET in raw from values file or generate it randomly.

secret: {{ .Values.core.secret | default (randAlphaNum 16) | b64enc | quote }}

We propose to use the same approach than secretKey or HARBOR_ADMIN_PASSWORD

  {{- if not .Values.existingSecretCoreSecret }}
  secret: {{ .Values.core-secret | default (randAlphaNum 16) | b64enc | quote }}
  {{- end }}
@zyyw
Copy link
Collaborator

zyyw commented Nov 2, 2023

Thanks for bring this up. Can you rise a PR for this?

@zyyw
Copy link
Collaborator

zyyw commented Nov 2, 2023

this PR might resolves this issue:

@zyyw zyyw closed this as completed Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants