Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make fdialog_project up to become the child of ProjectManager instead of child of ProjectDialog #94113

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Make fdialog_project up to become the child of ProjectManager instead of child of ProjectDialog #94113

merged 1 commit into from
Jul 19, 2024

Conversation

jsjtxietian
Copy link
Contributor

@jsjtxietian jsjtxietian commented Jul 9, 2024 •
edited
Loading

Fixes #94081

@AThousandShips AThousandShips added this to the 4.3 milestone Jul 9, 2024
@AThousandShips AThousandShips requested a review from KoBeWi July 9, 2024 14:18
@jsjtxietian jsjtxietian marked this pull request as ready for review July 16, 2024 07:12
@KoBeWi
Copy link
Member

KoBeWi commented Jul 18, 2024

To keep the code in ProjectDialog you can create the file dialog in NOTIFICATION_READY and use add_sibling() instead.

@KoBeWi
Copy link
Member

KoBeWi commented Jul 19, 2024 •
edited
Loading

This might be the reason:
image

@jsjtxietian
Copy link
Contributor Author

jsjtxietian commented Jul 19, 2024 •
edited
Loading

Yes I forgot to check the output, sorry :)

Done

@akien-mga akien-mga merged commit cca2201 into godotengine:master Jul 19, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@jsjtxietian jsjtxietian deleted the project-dialog branch July 19, 2024 15:52
@akien-mga akien-mga mentioned this pull request Aug 1, 2024
Closed
This was referenced Aug 2, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KoBeWi KoBeWi KoBeWi approved these changes

Assignees
No one assigned
Labels
bug regression topic:editor usability
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Project Manager looks like it is reporting an error when importing a new project
4 participants
@jsjtxietian @KoBeWi @akien-mga @AThousandShips