Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project Manager looks like it is reporting an error when importing a new project #94081

Closed
allenwp opened this issue Jul 8, 2024 · 1 comment · Fixed by #94113
Closed

Project Manager looks like it is reporting an error when importing a new project #94081

allenwp opened this issue Jul 8, 2024 · 1 comment · Fixed by #94113

Comments

@allenwp
Copy link
Contributor

allenwp commented Jul 8, 2024

Tested versions

  • Reproducible in v4.3.dev5.official [89f70e9] onward
  • Not reproducible in v4.3.dev4.official [df78c06] and earlier

Looking at the commit log, I suspect that this change might have been introduced by 2130f11

System information

Godot v4.3.beta2 - Windows 10.0.22631 - Vulkan (Mobile) - dedicated NVIDIA GeForce GTX 980 Ti (NVIDIA; 31.0.15.3598) - 13th Gen Intel(R) Core(TM) i7-13700K (24 Threads)

Issue description

When first clicking the Import button on the Project Manager, it appears as if an error message with red text is presented to the user, but then is quickly covered by the file selection window.

In previous versions of Godot, this error message and its red text was not shown until after a folder was selected:

2024-07-08.11-06-02.mp4

Personally, the red text of this error message caught my eye and made me think that there was an error happening with the project manager. This was not an issue previously because the red text error message would only appear after the user selected an invalid project or folder.

Steps to reproduce

  • Click the Import button in the Project Manager

Minimal reproduction project (MRP)

N/A

@jsjtxietian
Copy link
Contributor

jsjtxietian commented Jul 9, 2024

Looks like it related to this comment (The file dialog is the child of the Import Existing Project window) :

void ProjectDialog::ask_for_path_and_show() {
	// Workaround: for the file selection dialog content to be rendered we need to show its parent dialog.
	show_dialog();
	_browse_project_path();
}

I created a pr to demo my temp fix for this and tested locally, it works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Not Critical
5 participants