Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android Editor] Import button does not show folder content until Create button is pressed #94570

Closed
Hilderin opened this issue Jul 21, 2024 · 4 comments · Fixed by #95086
Closed

Comments

@Hilderin
Copy link
Contributor

Hilderin commented Jul 21, 2024

Tested versions

4.3 custom debug build from master

System information

Android 14 - Samsung A14

Issue description

In the Project Manager, when I press the Import button, the File dialog is at the root and I see no file or folder. When I press on Create and cancels that popup, I can press the Import button and the File dialog shows the correct files and folders.

In the logcat, I see this error:

07-20 22:29:40.247 23290 23354 E godot   : USER ERROR: Condition "id == 0" is true. Returning: ""
07-20 22:29:40.247 23290 23354 E godot   :    at: get_next (platform\android\dir_access_jandroid.cpp:67)

The other problem I see is when I select "SD Card" from the dropdown on the right corner, it does nothing. It always go back to "Internal shared storage". In fact, the files that are displayed in the File Dialog are from my SD Card even if "Internal shared storage is selected" so I don't known what this dropdown does exactly.

First Import press:
1000012161

Second Import press after Create popup:
1000012162

Steps to reproduce

  • Open Godot on Android
  • Press Import
  • No files or folders are displayed

Minimal reproduction project (MRP)

No project.

@Hilderin Hilderin changed the title [Android] Import button does not show folder content until Create button is pressed [Android Editor] Import button does not show folder content until Create button is pressed Jul 21, 2024
@akien-mga akien-mga added this to the 4.3 milestone Aug 1, 2024
@akien-mga akien-mga moved this from Unassessed to Bad in 4.x Release Blockers Aug 1, 2024
@akien-mga
Copy link
Member

I've seen that do while doing some tests a week or two ago.

I first thought it was a mismatch in scoped storage between a debug editor build and official release editor builds, the latter having access to Documents and the unsigned debug build being limited to app storage only.

But based on this report it seems that my hypothesis was wrong and I was just lucky to get it working in some builds and not in another.

@m4gr3d
Copy link
Contributor

m4gr3d commented Aug 1, 2024

I randomly ran into this issue yesterday. I'm traveling today so will try to take a look tomorrow.

@m4gr3d
Copy link
Contributor

m4gr3d commented Aug 2, 2024

The regression seems to start with the first release candidate. Beta 3 does not exhibit the described issue.

@m4gr3d
Copy link
Contributor

m4gr3d commented Aug 2, 2024

The root cause of the issue is #94113 and I have a tentative fix in #95086. I'm not familiar with that logic however so feedback are welcome on what the best resolution path would be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Bad
Development

Successfully merging a pull request may close this issue.

4 participants