Partially fix directory bug on Android

[shahriarlabib000]

Similar fix like #95086 for _browse_install_path() also updated _browse_project_path to account for local path.

But I couldn't fix for a directory that doesn't exist.

For example something like /storage/emulated/0/Documents/folderThatDoesntExist will still cause the same similar issue as mentioned in #94570

[m4gr3d]

Looks good enough to me to address the described issue.

Reiterating I'm not very familiar with the logic in project_dialog.cpp, but from #95086 and this fix, it seems we may need to revisit how its path validation is done.

[shahriarlabib000]

I'd like to add that this bug exist in the 4.2.0 as well (at least on my device Redmi 10 2022)

[KoBeWi]

When can this bug appear? It's weird that the path would be relative, unless it's some bug related only to Android? Like the path is dependent on system version or something. In #94570 it looks like the default should be /.

[shahriarlabib000]

This bug appears when importing from a ZIP file. relative path would be provided by the user.
https://youtu.be/_GNJwqWBsy0?si=Kc-jRdIaQ2Rq8JNN

[KoBeWi]

Yeah can't reproduce on Windows.
Although in your video the path changes to /, which is absolute. Does your fix handle it properly?

[shahriarlabib000]

I don't think I quite understand what you are saying.But i think its working
https://youtu.be/fut4N1qYeMM?si=VtS2ruvSqsyNpBa_
Although it doesn't work for a directory that doesn't exist hence the partial 'fix'
Maybe it could also be handled if we did something like dirAccess->dir_exists() check?

[KoBeWi]

Maybe it could also be handled if we did something like dirAccess->dir_exists() check?

That could work. You can use the dir_exists_absolute static method.

[shahriarlabib000]

Updated
only if(!DirAccess::dir_exists_absolute(path)) didn't seem to work had to write
if(path.is_relative_path() || !DirAccess::dir_exists_absolute(path))

[KoBeWi]

Sooo when importing ZIP file, the installation path is auto-filled with the ZIP-name, which is a new folder, which means it never exists. Clicking Browse will always reset path. Not sure what's the expected behavior tbh.

[KoBeWi]

I can't reproduce the problem (didn't test on Android though), but the fix seems harmless.

[shahriarlabib000]

Even tho it is similar issue as #94570 but the cause is different. This happens due to incorrect user input

[akien-mga]

Thanks! And congrats for your first merged Godot contribution 🎉

[akien-mga]

Cherry-picked for 4.3.1.