TileSet: Transform rotated navigation (sub)-polygons individually. #92955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libklein
force-pushed
the
fix-navigation-polygon-draw
branch
from
4b9efc4 to
60678de
Compare
kleonc
reviewed
Jun 10, 2024
kleonc
reviewed
Jun 13, 2024
There was a problem hiding this comment.
Overall LGTM, just some code style nitpicks.
Also please squash your commits, a single commit per PR is preferred.
The original implementation merged sub-polygons into a single polygon when rotating. This can cause non-simple geometries downstream algorithms cannot handle.
libklein
force-pushed
the
fix-navigation-polygon-draw
branch
from
a4fdeb3 to
2dc42e8
Compare
kleonc
approved these changes
Jun 14, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #92125.
This PR fixes the get_navigation_polygon function to ensure that individual sub-polygons of a NavigationPolygon2D are preserved when generating alternate (i.e., rotated, flipped, or transposed) tiles in TileSet.
This ensures that triangulation works properly, as unifying sub-polygons to a single polygon can create non-simple polygons.
Rotated tiles without the fix:
With the fix: