-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NavigationPolygon: Implement get
/set_polygon
fast paths.
#93171
NavigationPolygon: Implement get
/set_polygon
fast paths.
#93171
Conversation
362a265
to
fca467d
Compare
fca467d
to
bc48650
Compare
788ad1e
to
9420f1d
Compare
10e2af5
to
cd453bd
Compare
get
/set_polygon
fast paths.
Needs both a rebase for 4.4 and the newer thread locks added to the functions. |
cd453bd
to
fbafddc
Compare
Rebased onto the latest master:
|
Thank! Looks fine. I dont have any objection against the overload, that at least makes it clear that this function should never get exposed by accident. |
Looks good! Could you squash the commits? See PR workflow for instructions. |
53d5b05
to
63126a4
Compare
63126a4
to
a1fe6ff
Compare
Something went wrong with your rebase, which seemed to have amended changes into an unrelated merge commit from the I fixed it for you by resetting to the previous commit (53d5b05) and just running |
Thanks! |
Thank you! Is there any other issue I could assist with? |
Follow up to PR #92955. This PR implements the changes outlined in #92955 (comment).
As a first step, it implements fast-path
get/set_polygons
andget/set_outlines
functions, updatingNavMeshGenerator2D
accordingly. Implementedget/set_polygons
forNavigationMesh
as well, replacingadd_polygon
whenever a direct update was preferable.