Allow aborting SpinSlider value changes
#88275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
passivestar
commented
Feb 13, 2024
| @@ -1488,6 +1488,10 @@ Transform3D Node3DEditorViewport::_compute_transform(TransformMode p_mode, const | |||
| } | |||
|
|
|||
| void Node3DEditorViewport::_surface_mouse_enter() { | |||
| if (Input::get_singleton()->get_mouse_mode() == Input::MOUSE_MODE_CAPTURED) { | |||
There was a problem hiding this comment.
When the mouse cursor is captured by another element (i.e a SpinSlider), 3d viewport grabs focus and starts reacting to input. It happens only if it's in the middle of the screen at that time, so must be unintentional
There was a problem hiding this comment.
I've had this rarely occur even outside of this PR. This sounds good to me on paper.
There was a problem hiding this comment.
This section is a duplicate of #87642, I can confirm that it works. All good if this PR supersedes it since it does more than mine.
AThousandShips
changed the title
SpinSlider value changesSpinSlider value changes
|
This gets my personal approval but I'm neither part of Usability, nor Editor teams. |
ryevdokimov
suggested changes
Feb 15, 2024
KoBeWi
approved these changes
Feb 15, 2024
passivestar
force-pushed
the
slider-abort
branch
from
3d68163 to
5689dbc
Compare
ryevdokimov
approved these changes
Feb 16, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows you to use
right clickorescapeto abort changes while dragging sliders in Inspector, same way you can do it with viewport gizmosspinslider_abort.mp4
Closes godotengine/godot-proposals#9044
Closes #87639
Supersedes #87642