Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-freelook shortcuts can be triggered during freelook #87639

Closed
wgetJane opened this issue Jan 27, 2024 · 5 comments · Fixed by #88275
Closed

Non-freelook shortcuts can be triggered during freelook #87639

wgetJane opened this issue Jan 27, 2024 · 5 comments · Fixed by #88275

Comments

@wgetJane
Copy link

wgetJane commented Jan 27, 2024

Tested versions

4.3.dev2

System information

Godot v4.3.dev2 - Debian GNU/Linux 12 (bookworm) 12 - X11 - GLES3 (Compatibility)

Issue description

The freelook shortcuts (WASD and etc) can still trigger other shortcuts simultaneously during freelook mode in a 3D viewport

This is most likely unwanted behaviour because keyboard shortcuts shouldn't trigger two different things in different contexts at the same time

Steps to reproduce

  1. Go to the 3D workspace
  2. Create an AnimationPlayer node
  3. Create an animation in its animation editor (just leave it empty)
  4. Keep the animation editor open for the following steps
  5. Enable multiple viewports through the View menu
  6. Hold right-click on a 3D viewport to enter freelook mode
  7. Move the freelook camera left or right with the A and D keys
  8. Repeatedly perform steps 6-7 on multiple viewports
  9. Notice that the A and D keys will also simultaneously cause the animation to be played in the animation editor

Minimal reproduction project (MRP)

N/A

@wgetJane wgetJane changed the title Non-freelook shortcuts can be triggered during freelok Non-freelook shortcuts can be triggered during freelook Jan 27, 2024
@ryevdokimov
Copy link
Contributor

I can't replicate this:

Godot v4.3.dev2 - Windows 10.0.22631 - Vulkan (Forward+)

2024-01-26.22-26-41.mp4

@wgetJane
Copy link
Author

it seems like it only happens with multiple viewports and only after you use freelook on the leftmost topmost viewport:

simplescreenrecorder-2024-01-27_17.02.50.mp4

@ryevdokimov
Copy link
Contributor

ryevdokimov commented Jan 27, 2024

Oh, I missed the multiple viewport part. Yup, sure enough. Confirmed.

@wgetJane
Copy link
Author

Oh, I missed the multiple viewport part. Yup, sure enough. Confirmed.

oh i only edited those in afterwards, i didn't realise the issue was with multiple viewports yet

@ryevdokimov
Copy link
Contributor

ryevdokimov commented Jan 27, 2024

The PR mentioned above should fix it, if you'd like to test it: Testing pull requests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment