Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard shortcuts in Animation Editor remain active while multiple Viewports are active and in Freelook mode #74998

Closed
swfira opened this issue Mar 16, 2023 · 3 comments

Comments

@swfira
Copy link

swfira commented Mar 16, 2023

Godot version

4.0.1.rc1

System information

Windows

Issue description

The keyboard shortcuts for playback (A, S, D, Shift+A, Shift+D) in the Animation Editor remain usable while in Freelook mode in a 3D Editor Viewport when multiple viewports are open (View->2+ Viewports).

These shortcuts are the same as the default Freelook movement shortcuts, so moving around with WASD repeatedly jumps around in the Animation Editor, making it difficult to make animation adjustments.

This specifically only occurs when 2 or more Viewports are active in the Editor.
For only one of the Viewports, the animation shortcuts do not activate.
However, for all of the other Viewports, the animation shortcuts do activate.

The Animation Editor shortcuts do not activate when in Freelook mode with just 1 Viewport active.

Steps to reproduce

  1. Open the 3D Editor in a scene with an AnimationPlayer node.
  2. Select the AnimationPlayer node and open the Animation Editor.
  3. In the 3D Editor toolbar, select View->2 Viewports (The one that splits puts one at the top and the other at the bottom).
  4. In the 3D editor, in the top Viewport, enter Freelook mode by holding down the right mouse button.
  5. Move around in Freelook mode with WASD, and notice that the Animation Editor shortcuts are active when in the top Viewport.

Additional steps:
6. In the 3D editor, in the bottom Viewport, enter Freelook mode by holding down the right mouse button.
7. Move around with WASD, and notice that the Animation Editor shortcuts are not active when in the bottom Viewport.

Minimal reproduction project

N/A

@ModuleCode
Copy link

I also encountered this problem in v4.1.3.stable.official [f06b6836a]

@TheRedstoneScientist
Copy link

I have just experienced this in 4.2.2.rc1.mono

@ryevdokimov
Copy link
Contributor

Duplicate of: #87639

Which was solved by: #88275

Specifically, by the addition of this (because the title of the PR doesn't suggest anything to do with this issue):

void Node3DEditorViewport::_surface_mouse_enter() {
if (Input::get_singleton()->get_mouse_mode() == Input::MOUSE_MODE_CAPTURED) {
return;
}

@akien-mga akien-mga added this to the 4.3 milestone May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants