Ensure special characters are escaped in TSCN connections and editable hint

[LimestaX]

Fixes issue regarding #86347

• Bugsquad edit: Fixes Escape characters not implemented on connections #86347.

[LimestaX]

Originally was under #86348 , but I properly bricked my branch, this is a fresh build properly following guidelines, this is my first PR, and I tried using the web editor with Github, I didn't realize how bad that would make things, I couldn't properly rebase locally with the CLI nor VSCode.

[dalexeev]

Looks good to me. Please correct the commit message, it must start with a capital letter, see CONTRIBUTING.md.

[LimestaX]

All set! Thank you all for being patient.

[akien-mga]

I confirm the bug and the fix seems correct.

I skimmed through the file and found another occurrence that can have the same bug:

diff --git a/scene/resources/resource_format_text.cpp b/scene/resources/resource_format_text.cpp
index 29cd9f648d..b75b0280a0 100644
--- a/scene/resources/resource_format_text.cpp
+++ b/scene/resources/resource_format_text.cpp
@@ -2319,7 +2319,7 @@ Error ResourceFormatSaverTextInstance::save(const String &p_path, const Ref<Reso
 			if (i == 0) {
 				f->store_line("");
 			}
-			f->store_line("[editable path=\"" + editable_instances[i].operator String() + "\"]");
+			f->store_line("[editable path=\"" + editable_instances[i].operator String().c_escape() + "\"]");
 		}
 	}
 

Could you add it to this commit?

Overall I wonder if:

• We should prevent using \ in Node names/paths
• We should ensure NodePaths are always encoded with VariantWriter (i.e. as NodePath("Node\\"))

But both changes would be compat breaking, so this approach is the simplest solution for now.

[akien-mga]

I amended the commit with the further fix I suggested, so it should be ready to merge.

[akien-mga]

Thanks! And congrats for your first merged Godot contribution 🎉

[akien-mga]

Cherry-picked for 4.2.2.