Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape characters not implemented on connections #86347

Closed
LimestaX opened this issue Dec 20, 2023 · 3 comments · Fixed by #86417
Closed

Escape characters not implemented on connections #86347

LimestaX opened this issue Dec 20, 2023 · 3 comments · Fixed by #86417
Milestone

Comments

@LimestaX
Copy link
Contributor

LimestaX commented Dec 20, 2023

Tested versions

Reproduce able in 4.3.stable

System information

Windows 10 - vulkan Forward+ renderer, v4.3.stable

Issue description

Initial Issue:
Currently in live Godot 4.3 branch, accidentally inserted the "\" key at the end of a Node name. While adding and implemented the node, I connected a signal, saved and ran the scene, causing an issue with it immediately crashing, saved and relaunched to see the file could not be parsed, at some point in the process the following offending line was added.
image

Steps to reproduce

Rename a node to include \
example: new_button\
create a signal from the renamed node to any given node using the editor panel
save the scene
close and re-open scene to get parser error

Minimal reproduction project (MRP)

errorissue.zip

@LimestaX
Copy link
Contributor Author

seems like whichever code adds the [connection] line to the tscn file doesn't safely add the required escape character

@LimestaX LimestaX changed the title "\" used in node names prevents parsing of .TSCN Escape characters not implemented on connections Dec 20, 2023
@LimestaX
Copy link
Contributor Author

LimestaX commented Dec 20, 2023

Issue appears to be line 2293 in godot / editor / plugins / resource_format_text.cpp , I might be wrong, investigating if there are any current branches associated with this line

@LimestaX
Copy link
Contributor Author

LimestaX commented Dec 20, 2023

pull request created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants