Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure special characters are escaped in TSCN connections #86348

Closed
wants to merge 3 commits into from
Closed

Ensure special characters are escaped in TSCN connections #86348

wants to merge 3 commits into from

Conversation

LimestaX
Copy link
Contributor

@LimestaX LimestaX commented Dec 20, 2023 •
edited by dalexeev
Loading

Added c_escape to signal connection write strings. Original issue #86347

Bugsquad edit: Fixes #86347.

@LimestaX LimestaX changed the title c_issue: #86347 escape added to safely exit node paths issue: #86347 escape added to safely exit node paths Dec 20, 2023
@LimestaX LimestaX mentioned this pull request Dec 20, 2023
Closed
@dalexeev dalexeev added bug topic:core cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Dec 20, 2023
@dalexeev dalexeev added this to the 4.3 milestone Dec 20, 2023
@dalexeev dalexeev changed the title issue: #86347 escape added to safely exit node paths Fix special characters are not escaped in TSCN connections Dec 20, 2023
@dalexeev dalexeev requested a review from a team December 20, 2023 06:45
@LimestaX @dalexeev
Update scene/resources/resource_format_text.cpp
5eb42a9 
Fixed placement of escape function to String datatype

Co-authored-by: Danil Alexeev <[email protected]>
@LimestaX
Copy link
Contributor Author

@dalexeev Woops, thanks for catching that, added to commit

@LimestaX LimestaX requested a review from dalexeev December 21, 2023 00:11
@dalexeev
Copy link
Member

Please squash commits into one. To do this you need a local git client, GitHub web interface doesn't support it.

@AThousandShips AThousandShips changed the title Fix special characters are not escaped in TSCN connections Ensure special characters are escaped in TSCN connections Dec 21, 2023
@LimestaX
Copy link
Contributor Author

@dalexeev Okay, working on it.

@AThousandShips
Copy link
Member

You missed the git push --force part

@LimestaX LimestaX closed this by deleting the head repository Dec 22, 2023
@LimestaX LimestaX mentioned this pull request Dec 22, 2023
Merged
@AThousandShips AThousandShips added archived and removed cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Dec 22, 2023
@AThousandShips AThousandShips removed this from the 4.3 milestone Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalexeev dalexeev Awaiting requested review from dalexeev

Assignees
No one assigned
Labels
archived bug topic:core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Escape characters not implemented on connections
3 participants
@LimestaX @dalexeev @AThousandShips