Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit window size updates on title change. #85542

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Nov 30, 2023

Fixes #85537

Changes set_title to update window size only if keep_title_visible is set and title size is bigger than current limit.

@bruvzg bruvzg added this to the 4.3 milestone Nov 30, 2023
@bruvzg bruvzg requested a review from a team as a code owner November 30, 2023 14:05
@akien-mga akien-mga added the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Nov 30, 2023
Copy link
Contributor

@Riteo Riteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@akien-mga akien-mga merged commit e6d8305 into godotengine:master Dec 4, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@YuriSizov
Copy link
Contributor

Cherry-picked for 4.2.1.

@YuriSizov YuriSizov removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Window.set_title recreates swapchain
4 participants