Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit window size updates on title translation change. #85828

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Limit window size updates on title translation change. #85828

merged 1 commit into from
Dec 6, 2023

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Dec 6, 2023 •
edited by akien-mga
Loading

Adds the same check as in #85542, but for NOTIFICATION_TRANSLATION_CHANGED.

Bugsquad edit:

@bruvzg bruvzg added this to the 4.3 milestone Dec 6, 2023
@bruvzg bruvzg requested a review from a team as a code owner December 6, 2023 08:52
@akien-mga akien-mga added the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Dec 6, 2023
@saierXP
Copy link

saierXP commented Dec 6, 2023

It works for me. CC @Loneliiii

@akien-mga akien-mga merged commit 2f73a05 into godotengine:master Dec 6, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 4.2.1.

@akien-mga akien-mga removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
enhancement topic:gui
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Performance regression since 4.2-beta1 when calling TranslationServer.set_locale() every frame
3 participants
@bruvzg @saierXP @akien-mga