Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window.set_title recreates swapchain #85537

Closed
0x0ACB opened this issue Nov 30, 2023 · 0 comments · Fixed by #85542
Closed

Window.set_title recreates swapchain #85537

0x0ACB opened this issue Nov 30, 2023 · 0 comments · Fixed by #85542

Comments

@0x0ACB
Copy link
Contributor

0x0ACB commented Nov 30, 2023

Godot version

4.2

System information

Windows 10

Issue description

This commit 72e2e47 added _update_window_size to set_title for some reason:

_update_window_size();

This causes the Vulkan swapchain to be recreated each time the title is changed causing massive fps loss.

Steps to reproduce

func _process(_delta):
 var title = "fps: %d" % Engine.get_frames_per_second()
 get_window().set_title(title)

Minimal reproduction project

See steps to reproduce

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants