Fix Sprite3D to utilize 3D space by default #76461
Open
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes Sprite3D to use the depth prepass by default instead of render order. This makes Sprite3D more in line with its usage as a helper "to display a 2D texture in a 3D environment". Fixes godotengine#17567, godotengine#24069
CoolDotty
force-pushed
the
fix-sprite-3d-depth
branch
from
e3de2f1 to
d7fb537
Compare
|
I fixed the broken test. Although, sprites still cover gizmos in the editor. Notably the camera frustum and collision shape outlines.
For reference, this is what it should look like, demonstrated with
|
Calinou
reviewed
Apr 26, 2023
| @@ -86,7 +86,7 @@ class SpriteBase3D : public GeometryInstance3D { | |||
| RID last_texture; | |||
|
|
|||
| bool flags[FLAG_MAX] = {}; | |||
| AlphaCutMode alpha_cut = ALPHA_CUT_DISABLED; | |||
| AlphaCutMode alpha_cut = ALPHA_CUT_OPAQUE_PREPASS; | |||
There was a problem hiding this comment.
Note that changing a default parameter is a compatibility-breaking change, as it'll change behavior in existing projects that use the previous default mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Sprite3D to use the depth prepass by default instead of render order. This makes Sprite3D more in line with its usage as a helper "to display a 2D texture in a 3D environment".
IMO, alpha cut mode should be the most exhaustive mode by default, and adjusting it for better performance should be left to the user. This also addresses concerns with Sprite3D covering up Gizmos in the editor.
See #17567, #24069