Fix extension bindings for motion collision/result structs #74671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems some changes were made to
PhysicsServer3D::MotionCollision(#63650) andPhysicsServer3D::MotionResult(#64195) without updating the extension bindings defined inregister_server_types(), causing a mismatch in struct layout between the engine and (for example) godot-cpp. This means that when writing to certain fields of these structs from an extension, such as when implementingPhysicsServer3DExtension::_body_test_motion, you end up stomping on memory of other fields.This PR updates the bindings to again be in sync with the respective structs.