Allow to apply the angular velocity of a moving platform

[fabriceci]

I thought it was a bug but it was just more a limitation because it's not always wanted. This option adds a layer that allows to indicate if we have to apply or not the angular speed of a platform to the CharacterBody (as for the others)

EDIT: I added as reduz suggested a method to retrieve the angular velocity of the platform.

rotation.mp4

[Diddykonga]

Just making a note, but it seems like this should relate to Velocity On Leave, which is set using a enum, while this which relates to Rotational Velocity is set using layers, which is like how the walls and floors are set.
I'm not sure if Rotation should be like Velocity or vice versa ¯\(ツ)/¯

[fabriceci]

@Diddykonga In fact it's just that rotation is a boolean (yes or no, 2 values), whereas for velocity when leaving the platform there are 3 values (originally there were even more).

[and-rad]

I'm curious. Can you go into more detail about when it might not be desired for the character to follow the platform's rotation?

I would expect the floor to act like an actual floor and the character to always rotate with it. I think having yet another layer mask for this is pretty inconvenient.

Other than that I think the PR is great and adds a very important feature!

[rburing]

Would it be possible to do this instead by implementing a get_platform_angular_velocity method?

[fabriceci]

@and-rad Nothing specific, I was thinking about vertical rotations (or to make old school FPS)
We can make it a boolean (visible or not in the properties), or always apply it. Opinions are welcome on this.

@rburing The rotation is retrieved with get_angular_velocity, and it is applied in one line of code. I'm not sure I understand.

[reduz]

@rburing @fabriceci the method that get the velocity at a point does consider the angular velocity, the main problem with this is that most implementations will just rotate the mesh based on the direction and not really the collider or body.

Additionally, since most character control implementations will determine the facing direction based on velocity, this may conflict with it.

IMO, this would probably work better if the user could retrieve this angle after calling move_and_slide and decide what to do with it.

[fabriceci]

@reduz I added a method get_platform_angular_velocity() as you suggested.

[rburing]

Looks good to me.

[akien-mga]

Thanks!