Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML5: Properly skip Asset Library code in Web editor #62528

Closed
wants to merge 1 commit into from
Closed

HTML5: Properly skip Asset Library code in Web editor #62528

wants to merge 1 commit into from

Conversation

akien-mga
Copy link
Member

Follow-up to #61402.
Will need a cleanup as it's getting a bit messy.

Didn't actually test the changes yet. Have to go now, if someone else wants to confirm the fix, feel free to :)

@akien-mga
HTML5: Properly skip Asset Library code in Web editor
daafc2c 
Follow-up to godotengine#61402.
Will need a cleanup as it's getting a bit messy.

Fixes godotengine#62520.
@akien-mga akien-mga added bug platform:web topic:editor topic:assetlib crash cherrypick:3.x Considered for cherry-picking into a future 3.x release labels Jun 29, 2022
@akien-mga akien-mga added this to the 4.0 milestone Jun 29, 2022
@akien-mga akien-mga requested review from Calinou and Faless June 29, 2022 16:48
Faless
Faless reviewed Jun 29, 2022
View reviewed changes
Copy link
Collaborator

@Faless Faless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in 3.x and it works.
I think we should add a static AssetLib::is_available and use that though, since there might be multiple reasons as to why the assetlib is disabled.

@Faless Faless mentioned this pull request Jun 29, 2022
Merged
@akien-mga
Copy link
Member Author

Superseded by #62531.

@akien-mga akien-mga closed this Jun 29, 2022
@akien-mga akien-mga added archived and removed cherrypick:3.x Considered for cherry-picking into a future 3.x release labels Jun 29, 2022
@akien-mga akien-mga deleted the web-editor-fix-assetlib-crash branch June 29, 2022 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Faless Faless Faless left review comments

@Calinou Calinou Awaiting requested review from Calinou

Assignees
No one assigned
Labels
archived bug crash platform:web topic:assetlib topic:editor
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

Godot Web Editor 3.5 RC5 fully broken (since 3.5 RC 3)
2 participants
@akien-mga @Faless