-
-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTML5: Enable mbedTLS module for Crypto object, force disable Asset Library #61402
Conversation
ee6b01e
to
bbc2c3f
Compare
Also removed the matching notes from the documentation. Didn't test that the features actually work fine yet though. There's also still a similar note in WebSocketServer but I think this one is due to browser limitations and not mbedTLS? @Faless |
The Asset Library might need more work to be usable in the Web build, with this PR it's now enabled but spams warnings:
And it doesn't show any asset. There are also those two warnings when the asset lib plugin is set up:
|
As mentioned in chat, the asset library cannot work right now because browsers requires CORS which github (where the assets are hosted) do not allow. To support the asset library in the browsers we would need to either host or mirror the assets somewhere else, allowing CORS (at least from our domain). |
Yeah, browsers only have the client API, so there is no way to implement a WebSocketServer there. |
GitHub doesn't allow CORS so we can't download assets from it. There'd also be more work needed for the Asset Library plugin to be usable in the Web editor even if that was supported.
Increases the size of the wasm by around 3% (~300-350 KiB). This enables using the Crypto object for hashing, signing and encryption, and therefore reduces the gap between the features of the HTML5 platform and other platforms. Closes godotengine/godot-proposals#3574.
bbc2c3f
to
3ff6d79
Compare
I added a commit to always disable the Asset Library on HTML5 without relying on the availability of |
Cherry-picked for 3.5. |
Follow-up to godotengine#61402. Will need a cleanup as it's getting a bit messy. Fixes godotengine#62520.
Increases the size of the wasm by around 3% (~300-350 KiB).
This enables using the Crypto object for hashing, signing and encryption,
and therefore reduces the gap between the features of the HTML5 platform
and other platforms.
Closes godotengine/godot-proposals#3574.