[AssetLib] Fix crash in Web editor. #62531
Conversation
|
Maybe I should add the method to |
Faless
force-pushed
the
fix/4.x_assetlib_is_available
branch
from
a6aaa61 to
d4accf9
Compare
| @@ -7073,13 +7073,11 @@ EditorNode::EditorNode() { | |||
|
|
|||
| // Asset Library can't work on Web editor for now as most assets are sourced | |||
| // directly from GitHub which does not set CORS. | |||
| #ifndef JAVASCRIPT_ENABLED | |||
There was a problem hiding this comment.
You can also remove the comment here, it's sufficient to have it in is_available.
There was a problem hiding this comment.
@Faless notice me senpai :P
Doesn't matter so much though, I guess it doesn't hurt to repeat it here.
Just not very consistent in wording with what the warning would then print.
There was a problem hiding this comment.
oh, yeah, I had missed this comment, sorry :/
Good question. I never really understood the relationship between |
|
You should also update ProjectManager, see 42b4849 |
akien-mga
added
the
cherrypick:3.x
Faless
force-pushed
the
fix/4.x_assetlib_is_available
branch
from
d4accf9 to
bc8be60
Compare
Add EditorAssetLibrary::is_available which always returns false in the Web editor and use it in EditorNode for detection.
Faless
force-pushed
the
fix/4.x_assetlib_is_available
branch
from
bc8be60 to
0e504e4
Compare
|
Thanks! |
|
Cherry-picked for 3.5. Edit: For some reason this commit got lost? Eventually cherry-picked properly on 2022-07-08 with ad5fdcc. |
akien-mga
removed
the
cherrypick:3.x
Add EditorAssetLibrary::is_available which always returns false in the Web editor and use it in EditorNode for detection.
Fixes #62520.
Closes #62528