-
-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wake Physics Body on impulse and apply force. #52967
Wake Physics Body on impulse and apply force. #52967
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Nice work, thanks.
Please just squash your commits before we merge (see interactive rebase).
Also this fix would be nice to have in 3.4 as well to make Godot physics and Bullet work the same way. If you're up for it, you can open a separate PR on the 3.x
branch (it can't be cherry-picked because of file name changes).
Have squashed into one commit. |
Thanks! And congrats for your first merged Godot contribution 🎉 |
@danger-dan Congrats! Please let me know whether you would like to take care of backporting to 3.x. It would be the exact same change, but the body direct state methods are in |
Sorry for late reply. Yes I can manage that. I started looking through yesterday and didn't realise they were in the header! |
Use wakeup() function to wake sleeping bodies on impulse, force and velocities. Fix for PR #52967
Fixes #52915.
Set active on all apply forces/impulses functions. This wakes sleeping bodies from user input ( E.g. vehicleBody3D). Direct Transform change has been ignored.
note: set_active(bool) function checks against its current 'active' state in the function body.