Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use wakeup() function to wake sleeping bodies on impulse, force and velocities. Fix for PR #52967 #53365

Merged
merged 1 commit into from
Oct 5, 2021

Conversation

danger-dan
Copy link
Contributor

This PR tidies up a mistake in a previous PR where the active state was directly changed instead of using the wakeup() function (which checks against physics body type).

@danger-dan danger-dan requested a review from a team as a code owner October 3, 2021 19:02
@Calinou Calinou added this to the 4.0 milestone Oct 3, 2021
Copy link
Contributor

@pouleyKetchoupp pouleyKetchoupp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

Copy link
Contributor

@pouleyKetchoupp pouleyKetchoupp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah actually, I just realize the same changes should be done in 2D as well :)

…n direct body state changes (forces, impulses and veloicities). this 'bug' was introduced in PR #52967

added wakeup to 2d direct body
@pouleyKetchoupp pouleyKetchoupp merged commit 4778770 into godotengine:master Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants