Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a 2D scale factor property #21446

Closed
wants to merge 1 commit into from

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Aug 26, 2018

This can be used to make 2D elements larger or smaller, independently of the current stretch mode.

Only the disabled and 2d stretch modes support this new property.

Note that I removed the property hint for shrink as it was causing the Project Settings GUI to recognize it as a string instead of a floating-point value (it seems there's no way to add property hints for floats).

Demo project

@akien-mga
Copy link
Member

Moving to 3.2 milestone as we're about to enter the beta stage and release freeze for Godot 3.1. Only bug fixes against issues of the 3.1 milestone (or enhancements to core features of the 3.1 roadmap) will be considered until 3.1-stable is released.

Note: If it's merged after 3.1-stable is released, this change might be considered for cherry-picking into a later 3.1.x release.

@akien-mga akien-mga modified the milestones: 3.1, 3.2 Dec 12, 2018
@Calinou Calinou force-pushed the add-2d-scale-factor branch from 6ecd9dc to 956e487 Compare January 4, 2019 14:08
@Calinou Calinou force-pushed the add-2d-scale-factor branch from 956e487 to 7fb3680 Compare August 23, 2019 22:14
@Calinou Calinou requested a review from a team as a code owner August 23, 2019 22:14
@Calinou
Copy link
Member Author

Calinou commented Aug 23, 2019

I rebased this pull request against the current master branch. Could this be reviewed? This would make it possible to support hiDPI easily in one of my projects 🙂

@Calinou Calinou force-pushed the add-2d-scale-factor branch from 7fb3680 to 0d2fe75 Compare August 23, 2019 22:48
@akien-mga
Copy link
Member

The added option seems interesting, but I'm wary of doing such changes to SceneTree so late in the release cycle, so I'd prefer to postpone for 4.0.

This can and should still be reviewed properly ASAP - and if it's deemed safe to include in 3.2, I don't mind changing the milestone back.

This can be used to make 2D elements larger or smaller, independently
of the current stretch mode.

Only the `disabled` and `2d` stretch modes support this new property.
@aaronfranke
Copy link
Member

@Calinou Any update? This needs a rebase. Additionally, it would be nice if a proposal was created for this for discussion.

@Calinou
Copy link
Member Author

Calinou commented Jun 28, 2020

@aaronfranke 2d and viewport stretch modes are currently broken, so this can't be tested using the current master branch.

@aaronfranke
Copy link
Member

@Calinou I just checked, in the latest master the viewport and canvas_items (2d?) stretch modes seem to be working. It's likely that this PR can be rebased now, unless there is something else missing in master.

@Calinou
Copy link
Member Author

Calinou commented Aug 28, 2021

Superseded by #52170.

@Calinou Calinou closed this Aug 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants