Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: support HiDPI display / editor display scale setting #140

Closed
kezzbracey opened this issue Jan 27, 2020 · 7 comments · Fixed by #376
Closed

Feature request: support HiDPI display / editor display scale setting #140

kezzbracey opened this issue Jan 27, 2020 · 7 comments · Fixed by #376
Labels
change Proposes changes on how something works enhancement New feature or request help wanted Extra attention is needed

Comments

@kezzbracey
Copy link

Hi, thanks so much for the amazing work with Pixelorama!

It would be brilliant if there could be support for HiDPI displays as at the moment the interface is quite small in scale and a bit hard on the eyes:

pixelorama

Godot has a "Display Scale" setting for the editor that would solve the problem beautifully if it were possible to bring it across:

godotscaling

Thanks for considering, and for this great project. :)

@OverloadedOrama
Copy link
Member

Hello, thanks for the kind words and the suggestion! We have tried scaling the UI to support HiDPI displays, but for some reason the mouse coordinates in the canvas get messed up. I believe it is related to this Godot issue. I'm not sure how to fix it yet but I will try. I might need some help with this one though if anyone has any ideas!

@OverloadedOrama OverloadedOrama added enhancement New feature or request help wanted Extra attention is needed labels Jan 27, 2020
@Calinou
Copy link
Contributor

Calinou commented Jan 27, 2020

Adding proper hiDPI support for a non-game application is unfortunately not possible given what Godot currently exposes. This could be achieved once godotengine/godot#21446 is merged.

@OverloadedOrama
Copy link
Member

That's a bummer. So I guess we'll have to wait for Godot 4.0 to come out to solve the issue, since your PR to Godot belongs to the 4.0 milestone. Unless it's possible for it to be merged at a version like 3.2.1?

@Calinou
Copy link
Contributor

Calinou commented Jan 27, 2020

@OverloadedOrama Since the PR changes the function signature in a backwards-compatible manner, it could be merged into 3.2.1 but I can't guarantee that.

Edit: Godot 3.2.1 was released, so this will have to wait for 3.2.2 or later.
Edit 2: 3.2.2's release is too close now, so this will have to wait for 3.2.3 at least.

@OverloadedOrama OverloadedOrama added the change Proposes changes on how something works label Apr 16, 2020
@ghost
Copy link

ghost commented May 1, 2020

I'd love to see this as well. The app looks really great, but it's a bit too hard on the eyes on my 4k monitor. I'll keep an eye on it for future projects!

@adojck
Copy link

adojck commented May 30, 2020

I think this feature is very important as HiDPI displays are becoming very common. Currently it's pretty hard to use Pixelorama because of tiny UI on HiDPI screens. Hope to see this support soon!

@Calinou
Copy link
Contributor

Calinou commented May 30, 2020

@adojck I think the previous workaround could likely be fixed to not break mouse coordinates, which should make it usable again. See godotengine/godot#14542 (comment), except that we'll scale by a fixed factor (2.0) instead of a factor that varies depending on the window size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change Proposes changes on how something works enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants