Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing language in the project manager doesn't work on Android #60353

Open
Calinou opened this issue Apr 18, 2022 · 3 comments
Open

Changing language in the project manager doesn't work on Android #60353

Calinou opened this issue Apr 18, 2022 · 3 comments

Comments

@Calinou
Copy link
Member

Calinou commented Apr 18, 2022

Godot version

4.0.alpha6, 3.5.beta4

System information

OnePlus 6, Android 11 and Samsung Galaxy Fold2, Android 12

Issue description

This was first reported in #60344, but I can confirm it on two separate devices on both 3.5beta4 and 4.0alpha6.

This is likely caused by OS.set_restart_on_exit() not being implemented on Android, along with configuration file saving routines not being called in time before Android ends the activity.

As a workaround, we could hide the language selection dropdown in the project manager, but it'd be better to implement the required functionality to make it work. Or, even better, we can implement switching languages without having to restart the project manager or editor.

In the meantime, switching the language after creating a project in the Editor Settings should work, as long as you manually exit the editor instead of using the Save and Restart button (which has the same problem).

Steps to reproduce

  • Download Android editor from the 3.5beta4 release announcement.
  • Open project manager on an Android device.
  • Use the dropdown in the top-right corner to select another language.
  • Tap Save and Restart in the confirmation dialog.

Minimal reproduction project

N/A

@akien-mga
Copy link
Member

See https://github.com/godotengine/godot/pull/61211/files/9e64f3de6cdcaea43835643070810a2b175abe4c#diff-14e22e9144f620db2f6d4526b2d95442f0777303ad10b5c1690c328a100c728a, the language selection dialog has been hidden to work around this issue, but this should be fixed properly and made visible again eventually.

@Alex2782
Copy link
Contributor

See https://github.com/godotengine/godot/pull/61211/files/9e64f3de6cdcaea43835643070810a2b175abe4c#diff-14e22e9144f620db2f6d4526b2d95442f0777303ad10b5c1690c328a100c728a, the language selection dialog has been hidden to work around this issue, but this should be fixed properly and made visible again eventually.

= Merged, Could the language selection list be displayed again?
Not so important for me, perhaps a good task for label: “good first issue”

2 screenshots (V4.3 / V4.2.2)

Godot 4.3 on Android

image

Godot 4.2.2 on Windows (foreground) vs. on Android (background)

Screenshot 2024-07-24 230935

@akien-mga
Copy link
Member

= Merged, Could the language selection list be displayed again?

That PR that was merged is the one that his the language selection dropdown, as a workaround for this bug. It was a while ago but I don't see a reference that the actual feature of the language selection was fixed for Android (this bug).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants