Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project manager interface slides offscreen on Android editor due to labels being too long #60728

Closed
tremisabdoul opened this issue May 3, 2022 · 12 comments

Comments

@tremisabdoul
Copy link

tremisabdoul commented May 3, 2022

Godot version

3.5 alpha 4

System information

Android 6.0.1 - Samsung galaxy S5 neo - (Resolution: 1920x1080px)

Issue description

Hello!
I've seen an bug on the new Android Godot Editor.
I've install and run the 3.5 alpha 4 version but i can't use it.
The "Menu" of the editor didn't go fully on the right of the window (the scan, import, open, etc. are inaccessible). I think it's an screen calibration problem.

// Sorry for the language errors i'm french

Btw ty and gg guys for your work on godot :)
Have a nice day!

Steps to reproduce

Install 3.5 alpha 4 APK version on mobile and run it

Minimal reproduction project

No code needed

Bugsquad edit (keywords for easier searching): cut off, cutoff, trim, trimmed

@tremisabdoul
Copy link
Author

tremisabdoul commented May 3, 2022

Screenshot_20220503-172224
Screenshot_20220503-163259
Little screenshots to illustrate it.
The top bar is calibrate but the body isn't.

I've did the screenshot on the same phone but with an setting changes.
(1st screenshot: font size normal (defaut)
2nd screenshot: font size minimal (my setting))

@Calinou
Copy link
Member

Calinou commented May 3, 2022

This is due to the same cause as #31133.

You can alleviate this by changing the editor language to English, which uses shorter strings for most labels and buttons. However, you can currently only achieve this by changing the device language in the Android system settings due to #60353.

@Calinou Calinou changed the title Display bug on Godot Editor APK Project manager interface slides offscreen depending on language due to labels being too long May 3, 2022
@Calinou Calinou added this to the 4.0 milestone May 3, 2022
@tremisabdoul
Copy link
Author

Ok thank you (sorry i've didnt saw theres issues).

@KoBeWi KoBeWi moved this to Todo in 4.x Priority Issues May 4, 2022
@Calinou Calinou changed the title Project manager interface slides offscreen depending on language due to labels being too long Project manager interface slides offscreen on Android editor due to labels being too long May 4, 2022
@Calinou
Copy link
Member

Calinou commented May 4, 2022

For reference, here's what the project manager window looks like when you set its minimum size to 0, 0 (by recompiling the editor for this purpose):

simplescreenrecorder-2022-05-04_17.41.10.mp4

Things that can be done to reduce the minimum width required:

  • Make the search LineEdit shorter on small window sizes.
  • Check if project list doesn't impose a minimum width on its own – if it is, it probably shouldn't.
  • Display project icons at a lower size (or even hide them entirely) on very small window sizes.
  • Hide the version Label on very small window sizes (or truncate it).

Also, the About button should be hidden at small window sizes, as its dialog will probably look broken in those situations. In fact, the About dialog may not be able to be closed if it fills the whole screen, no hardware keyboard is connected to press Escape and the Close button isn't visible.

@akien-mga
Copy link
Member

akien-mga commented May 4, 2022

Check if project list doesn't impose a minimum width on its own – if it is, it probably shouldn't.

It definitely looks like it does, as it stops shrinking after a while even though the text clips and the other elements shouldn't impose a wider min width.

Setting the milestone to 3.5 as I think we should at least work this around properly for the Android editor in 3.5.

@akien-mga akien-mga modified the milestones: 4.0, 3.5 May 4, 2022
@JoluMorsanDev
Copy link

For reference, here's what the project manager window looks like when you set its minimum size to 0, 0 (by recompiling the editor for this purpose):

simplescreenrecorder-2022-05-04_17.41.10.mp4
Things that can be done to reduce the minimum width required:

  • Make the search LineEdit shorter on small window sizes.
  • Check if project list doesn't impose a minimum width on its own – if it is, it probably shouldn't.
  • Display project icons at a lower size (or even hide them entirely) on very small window sizes.
  • Hide the version Label on very small window sizes (or truncate it).

Also, the About button should be hidden at small window sizes, as its dialog will probably look broken in those situations. In fact, the About dialog may not be able to be closed if it fills the whole screen, no hardware keyboard is connected to press Escape and the Close button isn't visible.

I don't understand, is there a solution then? Or we have to wait? I have no problem but I want to know if I can do something (unless is very complex)

@Zireael07
Copy link
Contributor

@JoluMorsanDev: Can you compile Godot for Android or does that qualify as "very complex" for you?

@JoluMorsanDev
Copy link

@Zireael07 I don't know how to do it, but I can try, where do I find instructions?

@Calinou
Copy link
Member

Calinou commented May 5, 2022

@Zireael07 I don't know how to do it, but I can try, where do I find instructions?

See Compiling for Android in the documentation. You will need access to a PC to compile for Android. Also, remember to pass tools=yes on the SCons command line, then use ./gradlew generateGodotEditor within platform/android/java/ to generate an APK.

That said, if you don't make the required code changes explained above, compiling the editor for Android will not resolve this problem.

If you don't know how to fix this, this will take a while to be resolved, as most contributors have other priorities right now (and don't have time to dedicate to the Android editor).

@akien-mga
Copy link
Member

CC @m4gr3d. While we can and should improve the project manager so that it can support smaller sizes, this issue mostly shows that the choice of scaling ratio based on device DPI is not working well currently. On this device it shouldn't choose a scaling ratio that makes things so big.

The specs for that device seem to be:

Size | 5.1 inches, 71.7 cm2 (~69.6% screen-to-body ratio)
Resolution | 1080 x 1920 pixels, 16:9 ratio (~432 ppi density)

https://www.gsmarena.com/samsung_galaxy_s5_neo-6506.php

@JoluMorsanDev
Copy link

@Zireael07 I don't know how to do it, but I can try, where do I find instructions?

See Compiling for Android in the documentation. You will need access to a PC to compile for Android. Also, remember to pass tools=yes on the SCons command line, then use ./gradlew generateGodotEditor within platform/android/java/ to generate an APK.

That said, if you don't make the required code changes explained above, compiling the editor for Android will not resolve this problem.

If you don't know how to fix this, this will take a while to be resolved, as most contributors have other priorities right now (and don't have time to dedicate to the Android editor).

I work on pc so I don't have any problem wating, I just wanted to test it on android, anyways I'll try the compilation, thank you.

@akien-mga
Copy link
Member

This should have been pretty much fixed by #61210 and #61595 in 3.5.

If some similar issues are still reproducible in 3.5.x or later, please open a new issue.

Repository owner moved this from Todo to Done in 4.x Priority Issues Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants