Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project manager receiving joypad input when starting project via Run-button #15199

Closed
1 task done
BeayemX opened this issue Dec 30, 2017 · 5 comments
Closed
1 task done
Assignees
Milestone

Comments

@BeayemX
Copy link
Contributor

BeayemX commented Dec 30, 2017

Godot version:
using Godot 3, the latest master version 0294887

OS/device including version:
Linux Mint
using an Xbox 360 controller

Issue description:
When running a project from the Project Manager window the input is process by the game and also by the Project Manager window.

Steps to reproduce:

  1. Open Project Manager
  2. Run any project (not Edit!)
  3. Move game window out of the way to see the Project Manager
  4. Use Joypad while game window has focus (eg. dpad for button switching or A to click on buttons)
  5. See that the input is also processed in the Project Manager
  • I searched the existing GitHub issues for potential duplicates.
@27thLiz 27thLiz added this to the 3.0 milestone Dec 30, 2017
@brainsick
Copy link
Contributor

Ubuntu 17.10, Godot 3.0 Beta 2, AMD Radeon R9 Fury, Joypads demo, Microsoft X-Box One pad

I can recreate this. Joypad demo has focus and is responsive to the controller. Project Manager responds to directional pad and the A button.

@akien-mga
Copy link
Member

We have now entered release freeze for Godot 3.0 and want to focus only on release critical issues for that milestone. Therefore, we're moving this issue to the 3.1 milestone, though a fix may be made available for a 3.0.x maintenance release after it has been tested in the master branch during 3.1 development. If you consider that this issue is critical enough to warrant blocking the 3.0 release until fixed, please comment so that we can assess it more in-depth.

@BeayemX
Copy link
Contributor Author

BeayemX commented Feb 7, 2018

I just noticed, that this is not only limited to the Project Manager window. When running multiple Godot games all games will receive the joypad input. It does not matter if the games are started from the editor or if they are run from the commandline.

@akien-mga
Copy link
Member

I'll have a look at refactoring the mess in main.cpp so that the project manager and editor get a similar setup. Currently some things are set only when editor is defined, but they are relevant for the project manager too (such as HiDPI support - see #16407).

@akien-mga akien-mga self-assigned this Feb 13, 2018
akien-mga added a commit to akien-mga/godot that referenced this issue Feb 19, 2018
The Project Manager should share the same settings as the editor most of the time.
The whole init stuff with Main::setup and Main::start needs a good cleanup though.

Fixes godotengine#15199.
@akien-mga
Copy link
Member

I just noticed, that this is not only limited to the Project Manager window. When running multiple Godot games all games will receive the joypad input. It does not matter if the games are started from the editor or if they are run from the commandline.

Note that I only fixed it for the project manager, by disabling its support for game-specific input.

The fact that multiple instances of a game all receive joypad events regardless of the focus would likely be worth keeping track of in a new issue (if not done already).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants