Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent loading project-specific config in Project Manager #16819

Merged
merged 1 commit into from
Feb 19, 2018

Conversation

akien-mga
Copy link
Member

The Project Manager should share the same settings as the editor most of the time.
The whole init stuff with Main::setup and Main::start needs a good cleanup though.

Fixes #15199.

The Project Manager should share the same settings as the editor most of the time.
The whole init stuff with Main::setup and Main::start needs a good cleanup though.

Fixes godotengine#15199.
@akien-mga akien-mga added this to the 3.1 milestone Feb 19, 2018
@akien-mga akien-mga merged commit 4faf819 into godotengine:master Feb 19, 2018
@akien-mga akien-mga deleted the pm-setup branch February 19, 2018 13:41
@akien-mga
Copy link
Member Author

@hpvb Give this one a few days of testing in the master branch before cherry-picking, the Main stuff is hairy and my additions of some project_manager checks might have some unintended consequences.

@akien-mga
Copy link
Member Author

akien-mga commented Feb 21, 2018

Actually Main stuff is too sensitive, best not cherry-pick and risk regressions for such a small issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant