Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add German localization #1020

Closed
wants to merge 1 commit into from
Closed

Add German localization #1020

wants to merge 1 commit into from

Conversation

paddy-exe
Copy link
Contributor

@paddy-exe paddy-exe commented Feb 28, 2025 •
edited
Loading

Based on the localization support from #1011

Will very probably need some correction perhaps from other German speaking people. I tried to avoid using personal pronouns as that is always a hard bargain in German...

@MurderVeggie Would you mind going over the changes if you have the time? Would very much appreciate it.

mhilbrunner
mhilbrunner reviewed Feb 28, 2025
View reviewed changes
Copy link
Member

@mhilbrunner mhilbrunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick review, some thoughts and nitpicks.

_i18n/de.yml Outdated
description: Entwickle 2D- und 3D-Spiele, plattformübergreifenden Projekte oder sogar XR-Ideen!
header:
features: Features
showcase: Vorzeigeprojekte
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, leaving it as Showcase feels less corporate while just as clear, also half as long.

_i18n/de.yml Outdated
features: Features
showcase: Vorzeigeprojekte
blog: Blog
community: Gemeinschaft
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likewise, I suggest leaving this as Community.

_i18n/de.yml Outdated
text: Godot's 3D Nodes bieten alles, was zur Erstellung, Animierung und Renderng von 3D-Welten Charakteren benötigt wird.
deploy:
title: Veröffentliche auf allen Plattformen
text: Stelle dein Spiel in Sekundenschnelle für die Desktop-, Mobil- und Webplattform bereit. Godot unterstützt sogar Konsolen durch Drittanbieter.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
text: Stelle dein Spiel in Sekundenschnelle für die Desktop-, Mobil- und Webplattform bereit. Godot unterstützt sogar Konsolen durch Drittanbieter.
text: Stelle dein Spiel in Sekunden für Desktop-, Mobil- und Webplattformen bereit. Über Drittanbieter unterstützt Godot sogar Konsolen.

Especially the emphasis/word order change in the latter sentence.

MurderVeggie
MurderVeggie reviewed Feb 28, 2025
View reviewed changes
_i18n/de.yml Outdated
meta:
description: Entwickle 2D- und 3D-Spiele, plattformübergreifenden Projekte oder sogar XR-Ideen!
header:
features: Features
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
features: Features
features: Eigenschaften

I would try to translate as much as possible, and leave as little in English as we can manage.

Sometimes that means looking for less direct translations rather than synonyms already used in comparable scenarios, here: https://www.linguee.com/english-german/translation/software+features.html

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case I think we should go for Funktionen as Eigenschaften would be farther away from the meaning behind features. Funktionen define what you can do. Eigenschaften define what is.

MurderVeggie
MurderVeggie reviewed Feb 28, 2025
View reviewed changes
MurderVeggie
MurderVeggie reviewed Feb 28, 2025
View reviewed changes
MurderVeggie
MurderVeggie reviewed Feb 28, 2025
View reviewed changes
_i18n/de.yml Outdated
footer:
download: Download
documentation: Dokumentation
features: Features
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
features: Features
features: Eigenschaften

Same as above

MurderVeggie
MurderVeggie reviewed Feb 28, 2025
View reviewed changes
MurderVeggie
MurderVeggie reviewed Feb 28, 2025
View reviewed changes
MurderVeggie
MurderVeggie reviewed Feb 28, 2025
View reviewed changes
MurderVeggie
MurderVeggie reviewed Feb 28, 2025
View reviewed changes
MurderVeggie
MurderVeggie reviewed Feb 28, 2025
View reviewed changes
MurderVeggie
MurderVeggie reviewed Feb 28, 2025
View reviewed changes
Copy link
Collaborator

@MurderVeggie MurderVeggie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At some point it made sense to open a review instead of commenting

_i18n/de.yml
text: Wenn Sie an einem Unternehmensponsoring interessiert sein, schreiben Sie bitte an <a href='mailto:[email protected]'>[email protected]</a>.<br>Spenden als Einzelpersonen können durch den <a href='https://fund.godotengine.org/'>Godot Engine Entwicklungsfonds</a> getätigt werden.
cta: Spenden
home:
h1: Deine kostenlose, Open&#8209;Source<br>Game Engine.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
h1: Deine kostenlose, Open&#8209;Source<br>Game Engine.
h1: Deine kostenlose, Open&#8209;Source<br>Videospiel Engine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really think we should stick to Game Engine here. Nobody to my knowledge calls it Videospiel Engine in either spoken German or German literature.

_i18n/de.yml Outdated
cta: Mehr über Godot lernen
get_involved:
title: Mitwirken
text: Trete der Gemeinschaft bei und helfe mit, eine Game Engine zu entwicklen, die allen gehört.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
text: Trete der Gemeinschaft bei und helfe mit, eine Game Engine zu entwicklen, die allen gehört.
text: Trete der Online-Community bei und helfe mit, eine Videospiel Engine zu entwicklen, die allen gehört.

This one I am unsure about

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should stick to Game Engine as it's often everywhere I've seen in written literature.

The other one is good👍🏻

_i18n/de.yml
text: Wenn du weißt, wie man programmiert, kannst du helfen, indem du Fehler behebst und mit anderen Beitragenden an der Implementierung neuer Funktionen arbeitest.
document:
title: Dokumentation
text: Die Qualität der Dokumentation ist für eine Game Engine essentiell. Helfe mit sie zu verbessern, indem du die API-Referenz aktualisierst, neue Anleitungen schreibst oder Verbesserungen beiträgst.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
text: Die Qualität der Dokumentation ist für eine Game Engine essentiell. Helfe mit sie zu verbessern, indem du die API-Referenz aktualisierst, neue Anleitungen schreibst oder Verbesserungen beiträgst.
text: Die Qualität der Dokumentation ist für eine Videospiel Engine grundlegend. Helfe mit sie zu verbessern, indem du die API-Referenz aktualisierst, neue Anleitungen schreibst oder Verbesserungen beiträgst.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

@adamscott adamscott force-pushed the master branch 2 times, most recently from 25b0f65 to d7fb26a Compare February 28, 2025 14:20
@paddy-exe
Add German localization
fe7a879 
Based on the localization support from
godotengine#1011

First feedback
@paddy-exe
Copy link
Contributor Author

paddy-exe commented Feb 28, 2025 •
edited
Loading

I will need to close the pull request due to the conflicts. I forgot to create a separate branch for rebasing :/ Will create a new one with a fresh branch

@paddy-exe paddy-exe closed this Feb 28, 2025
@paddy-exe paddy-exe mentioned this pull request Feb 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhilbrunner mhilbrunner mhilbrunner left review comments

@MurderVeggie MurderVeggie MurderVeggie left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paddy-exe @mhilbrunner @MurderVeggie