Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve wording #9943

Closed
wants to merge 173 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
173 commits
Select commit Hold shift + click to select a range
a3e4e9b
Add commas before "but" throughout documentation
russellsanborn Jul 6, 2024
9d2a54f
Update about/faq.rst
russellsanborn Jul 9, 2024
c94407f
Update tutorials/2d/custom_drawing_in_2d.rst
russellsanborn Jul 9, 2024
525df8f
Update getting_started/first_3d_game/03.player_movement_code.rst
russellsanborn Jul 9, 2024
4e8142a
Update contributing/documentation/docs_writing_guidelines.rst
russellsanborn Jul 9, 2024
bb17829
Update contributing/documentation/docs_image_guidelines.rst
russellsanborn Jul 9, 2024
0c10476
Update contributing/development/core_and_modules/object_class.rst
russellsanborn Jul 9, 2024
5908691
Update contributing/development/compiling/introduction_to_the_buildsy…
russellsanborn Jul 9, 2024
a71c5cd
Update contributing/development/core_and_modules/core_types.rst
russellsanborn Jul 27, 2024
7011117
Update contributing/development/core_and_modules/object_class.rst
russellsanborn Jul 27, 2024
97f2823
Remove "," in object_class.rst, add "code" to code_style_guidelines.rst
russellsanborn Jul 27, 2024
f10b322
Fix description of typed resource exports
esainane Aug 6, 2024
dd9448f
Bump version
mhilbrunner Aug 15, 2024
c33e058
Merge pull request #9752 from mhilbrunner/bump-version
mhilbrunner Aug 15, 2024
03f966a
Fix project structure diagram in gdextension docs system docs
paddy-exe Aug 15, 2024
387d5f8
Fix glTF capitalization in manual
tetrapod00 Aug 15, 2024
1228ab4
Merge pull request #9753 from paddy-exe/fix-project-structure-docs-gd…
mhilbrunner Aug 15, 2024
afe1c82
Update iOS system requirements.
bruvzg Aug 15, 2024
c476471
This PR adds graphs showing the behavior of the smoothstep function w…
Malcolmnixon Aug 15, 2024
35e2adc
Merge pull request #9754 from tetrapod00/gltf-capitalization-manual
skyace65 Aug 16, 2024
b54f912
Merge pull request #9582 from russellsanborn/comma-before-but
skyace65 Aug 16, 2024
f48748a
Fix compile error in advanced_postprocessing.rst
tetrapod00 Aug 16, 2024
f3beeb7
Merge pull request #9764 from tetrapod00/fog-disabled-advanced-postpr…
skyace65 Aug 16, 2024
0f8477a
Update navigation_using_navigationagents.rst
cordellbonnieux Aug 17, 2024
5a25f53
classref: Sync with current master branch (1bd740d)
Aug 17, 2024
42145e8
Merge pull request #9758 from bruvzg/ios_req
mhilbrunner Aug 17, 2024
0fe736b
Update 07.killing_player.rst
darkstarworks Aug 17, 2024
49a432d
Fix Visual Studio Code gdb pretty print script path to match the Godo…
Calinou Aug 17, 2024
1247426
Update 18_register_autoload.webp
darkstarworks Aug 17, 2024
4664e7a
Updated images to match docs
darkstarworks Aug 17, 2024
861eb13
Update tutorials/navigation/navigation_using_navigationagents.rst
cordellbonnieux Aug 17, 2024
d49dfae
Add example to advanced_postprocessing.rst
tetrapod00 Aug 16, 2024
5dd72ba
Merge pull request #9774 from Calinou/vscode-fix-gdb-script-path
mhilbrunner Aug 18, 2024
f5fcba7
Fix make html with filelist command in building_the_manual.rst
tetrapod00 Aug 20, 2024
ea604c4
Update release policy information on Godot 4.3 (#9755)
Infiland Aug 20, 2024
3414754
[GDExtension] Add missing iOS instructions and build/config example c…
bruvzg Aug 15, 2024
1d05bdd
Corrected typo in gdscript_basics.rst
MajorGonzo Aug 20, 2024
c138ee0
C#: Remove references to GODOT_SERVER and GODOT_HTML5 defines
raulsntos Aug 20, 2024
ce997a0
Merge pull request #9793 from raulsntos/dotnet/defines
skyace65 Aug 21, 2024
58f0770
Merge pull request #9791 from MajorGonzo/master
skyace65 Aug 21, 2024
094ac0a
Merge pull request #9788 from tetrapod00/building-manual-make-filelist
skyace65 Aug 21, 2024
f31489b
Merge pull request #9713 from esainane/dancestors
skyace65 Aug 21, 2024
be8e0d5
Merge pull request #9773 from darkstarworks/master
skyace65 Aug 21, 2024
f0d9618
Fix comment directive to prevent webpage display
esainane Aug 21, 2024
b6e3e5b
Merge pull request #9790 from bruvzg/gde_ios
mhilbrunner Aug 21, 2024
689cc55
Fix out of date comment about depth buffer
sfreed141 Aug 21, 2024
1143447
Merge pull request #9800 from sfreed141/patch-2
skyace65 Aug 22, 2024
e98b2c7
Merge pull request #9767 from cordellbonnieux/patch-1
skyace65 Aug 22, 2024
83f6133
Add C# examples to Using Viewports documentation
ShawnHardern Aug 22, 2024
f27d129
Update certain example code snippets to use the new syntax
gongpha Aug 22, 2024
3b888cb
Merge pull request #9805 from gongpha/v3-style-to-v4-style
mhilbrunner Aug 23, 2024
1375925
Merge pull request #9796 from esainane/no-comment
mhilbrunner Aug 23, 2024
6950a91
Merge pull request #9768 from godotengine/classref/sync-1bd740d
mhilbrunner Aug 23, 2024
35c34b3
Add C# examples to Occlusion culling
ShawnHardern Aug 23, 2024
d24c0c3
Add C# examples to Mesh level of detail
ShawnHardern Aug 23, 2024
271d4ff
Add link to `godot-proposals` in the issue template
AThousandShips Aug 23, 2024
6a68d3e
Add C# examples to Using NavigationRegions
ShawnHardern Aug 23, 2024
0c5d686
Add C# examples to Using NavigationMaps
ShawnHardern Aug 23, 2024
edb2b85
Merge pull request #9812 from ShawnHardern/update-using-navigationmap…
AThousandShips Aug 23, 2024
eef7d06
Merge pull request #9815 from ShawnHardern/update-mesh-load-csharp
AThousandShips Aug 23, 2024
f3ddfc3
Merge pull request #9814 from ShawnHardern/update-occlusion-culling-c…
AThousandShips Aug 23, 2024
69fe8f0
Merge pull request #9813 from ShawnHardern/update-using-navigation-re…
AThousandShips Aug 23, 2024
0edbe34
Add C# examples to CPU optimization
ShawnHardern Aug 23, 2024
b685a63
Merge pull request #9810 from ShawnHardern/update-CPU-optimization-cs…
AThousandShips Aug 23, 2024
c4a17ab
Add C# examples to High-level Multiplayer documentation
ShawnHardern Aug 21, 2024
f3bf2ca
Merge pull request #9798 from ShawnHardern/update-high-level-multipla…
AThousandShips Aug 23, 2024
93fa10d
Add C# examples to Background loading
ShawnHardern Aug 23, 2024
6475321
Add C# examples to Creating movies
ShawnHardern Aug 23, 2024
20f5a27
Merge pull request #9820 from ShawnHardern/update-background-loading-…
AThousandShips Aug 23, 2024
c0d608c
Merge pull request #9816 from ShawnHardern/update-creating-movies-csharp
AThousandShips Aug 23, 2024
88d2383
Merge pull request #9804 from ShawnHardern/update-viewports-examples-…
skyace65 Aug 23, 2024
d56905c
Merge pull request #9819 from AThousandShips/proposal_instruction
mhilbrunner Aug 24, 2024
e0628f0
classref: Sync with current master branch (e3550cb)
Aug 24, 2024
c9667d9
Merge pull request #9823 from godotengine/classref/sync-e3550cb
mhilbrunner Aug 24, 2024
2a252ae
Add C# examples to Playing videos
ShawnHardern Aug 23, 2024
6b1bd26
Merge pull request #9817 from ShawnHardern/update-playing-videos-csharp
AThousandShips Aug 24, 2024
37e549e
remove article before plural noun from autoloads_versus_internal_node…
Lukas-Fletcher Aug 24, 2024
fee3226
update editing pages online instructions in contributing_to_the_docum…
Lukas-Fletcher Aug 24, 2024
1cb5f0a
Document physics interpolation not being supported in 2D particles yet
Calinou Aug 24, 2024
1508be4
Merge pull request #9827 from Lukas-Fletcher/patch-1
skyace65 Aug 25, 2024
626d31d
2d movement click and move
HubbleCommand Aug 25, 2024
199fb54
2d movement explicit drag
HubbleCommand Aug 25, 2024
5425bf6
2d movement indent
HubbleCommand Aug 25, 2024
7154161
2d movement click movement drag corrections
HubbleCommand Aug 25, 2024
a81cc1b
2d movement click move update cs
HubbleCommand Aug 25, 2024
326abe7
Merge branch 'master' of https://github.com/HubbleCommand/godot-docs
HubbleCommand Aug 25, 2024
118408e
Update animations text in data_preferences.rst
Lukas-Fletcher Aug 25, 2024
f7d90c9
Merge pull request #9836 from Lukas-Fletcher/patch-3
skyace65 Aug 25, 2024
8229202
Update codespell path and fix spelling errors
Piralein Aug 23, 2024
59de155
2d movement click cs StringName
HubbleCommand Aug 26, 2024
8a868a4
2d movement cs event par
HubbleCommand Aug 26, 2024
443d5e9
Add documentation for GDScript when statement
tetrapod00 Aug 20, 2024
7628f87
Merge pull request #9811 from Piralein/spellcheck
mhilbrunner Aug 26, 2024
164f7e3
Added screenshot to first_2d_game/player_scene for clarity
choidavid4 Aug 27, 2024
e09439a
Add missing C# code examples to documentation
ShawnHardern Aug 25, 2024
586a2fd
Improve next_pass documentation in Standard Material 3D (#9762)
huwpascoe Aug 28, 2024
728eb34
[Contributing] Improve list of classes disabled by `disable_advanced_…
AThousandShips Aug 28, 2024
d459bb9
Merge pull request #9833 from ShawnHardern/update-csharp-docs
AThousandShips Aug 28, 2024
b7b2b52
Update misspelled word in using_tilesets.rst
Lukas-Fletcher Aug 28, 2024
7f8387e
Merge pull request #9855 from Lukas-Fletcher/patch-5
skyace65 Aug 29, 2024
4010ab4
Merge pull request #9829 from Calinou/particles-no-physics-interpolation
mhilbrunner Aug 29, 2024
ff66473
Merge pull request #9787 from tetrapod00/gdscript-when
mhilbrunner Aug 29, 2024
7698f62
Update SSL/TLS networking tutorial (#9847)
Faless Aug 29, 2024
19e57bb
Merge pull request #9854 from AThousandShips/adv_gui_doc_improve
skyace65 Aug 31, 2024
f54bb92
Fix decals demo link in Using decals
Calinou Aug 31, 2024
a4d82ae
Merge pull request #9864 from Calinou/decals-fix-demo-link
mhilbrunner Aug 31, 2024
c2cd63b
classref: Sync with current master branch (61598c5)
Aug 31, 2024
87812dc
Merge pull request #9867 from godotengine/classref/sync-61598c5
mhilbrunner Aug 31, 2024
e86ffe9
Fix PascalCasing in using_tilemaps.rst
Lukas-Fletcher Aug 31, 2024
5db2120
Update TileMap node with Layer postfix in using_tilemaps.rst
Lukas-Fletcher Aug 31, 2024
0686612
[GDScript] Clarify initialization of enum values
AThousandShips Aug 31, 2024
a2c22b4
Remove confusing end of sentence from the_profiler.rst documentation
gachipan Aug 31, 2024
9c3fcbe
Add missing comma
bobby-the-epic Aug 31, 2024
e9ef898
Changed Autoload to Globals -> Autoload
Elzair Sep 1, 2024
ff5a7fc
Merge pull request #9875 from gachipan/patch-2
skyace65 Sep 1, 2024
2c80b1d
Merge pull request #9869 from Lukas-Fletcher/patch-6
skyace65 Sep 1, 2024
9461358
Merge pull request #9877 from bobby-the-epic/patch-1
skyace65 Sep 1, 2024
85cc4bf
Merge pull request #9879 from Elzair/patch-1
skyace65 Sep 1, 2024
09b3b00
Merge pull request #9870 from Lukas-Fletcher/patch-7
skyace65 Sep 1, 2024
9dbc6f8
Merge pull request #9844 from choidavid4/master
skyace65 Sep 1, 2024
2d792b4
Merge pull request #9872 from AThousandShips/enum_doc_improve
mhilbrunner Sep 1, 2024
f195efe
Add Arm Performance Tools to suggested performance tools list.
dazedjade Sep 2, 2024
bfeb5ee
Merge pull request #9890 from dazedjade/patch-1
skyace65 Sep 2, 2024
4726e13
Document PackedVector4Array
Calinou Aug 31, 2024
b66dc5a
Merge pull request #9865 from Calinou/add-packedvector4array
mhilbrunner Sep 3, 2024
edfc559
Bump peter-evans/create-pull-request from 6 to 7
dependabot[bot] Sep 3, 2024
c734502
Correct "ConnectionCheck" return type
Brederodes Sep 3, 2024
badeecb
Add info to turn off preview sunlight before working with 3D shader …
FarzadBT Sep 3, 2024
909af5c
toggle off -> turn off
FarzadBT Sep 3, 2024
b07c27f
Add note about the create_test.py script
Geometror Sep 4, 2024
d68f5ff
Mention --no-deprecated in Compiling with .NET
Drako Sep 4, 2024
52eefaf
Merge pull request #9897 from FarzadBT/FarzadBT-patch-1
skyace65 Sep 5, 2024
b95f46f
Fix incorrect setup instructions in The profiler
Calinou Sep 5, 2024
5c4342c
Fix keywords for Vector in GDScript syntax highlighting
Calinou Aug 31, 2024
a37703e
Merge pull request #9907 from Calinou/profiler-fix-instructions
skyace65 Sep 5, 2024
f4a38c9
Merge pull request #9866 from Calinou/gdscript-lexer-fix-vector-types
skyace65 Sep 5, 2024
8a922af
Merge pull request #9835 from HubbleCommand/master
skyace65 Sep 5, 2024
22db647
Modified the using_tilesets.rst, section assigning-custom-metadata-to…
EastToastLiving Aug 29, 2024
b0c7081
Merge pull request #9828 from Lukas-Fletcher/patch-2
skyace65 Sep 5, 2024
c504fc3
Fix sprite position in code sample in Optimization using servers
Calinou Sep 5, 2024
11e0393
Merge pull request #9909 from Calinou/using-servers-fix-code-sample
skyace65 Sep 5, 2024
2a85b24
Add compilation instructions for RISC-V
MBCX Aug 29, 2024
fccf532
Document testing signals
Geometror Sep 5, 2024
c855ff7
Removed outdated information about Mono SDK beeing necessary
Nijco Sep 5, 2024
973e5e6
Merge pull request #9914 from Nijco/master
skyace65 Sep 6, 2024
b507765
Merge pull request #9901 from Drako/godotsharp-no-deprecated
skyace65 Sep 6, 2024
5009868
Update Discord, refer to website for communities
mhilbrunner Aug 7, 2024
934a3e2
Merge pull request #9716 from mhilbrunner/website-communities
akien-mga Sep 6, 2024
fe80ff2
Fix `ADD_PROPERTY()` calls in GDExtension C++ example to use correct …
Calinou Sep 6, 2024
688d037
Fix typos in tutorials/animation/introduction.rst (#9917)
codingthat Sep 7, 2024
35df92c
classref: Sync with current master branch (5675c76)
Sep 7, 2024
aa297fd
Merge pull request #9862 from MBCX/riscv-cross-compilation
skyace65 Sep 7, 2024
5980166
Merge pull request #9899 from Geometror/note-about-create-test-py
skyace65 Sep 7, 2024
4d42b74
Merge pull request #9766 from tetrapod00/advanced-postprocessing-example
skyace65 Sep 7, 2024
9202c89
Update getting started 2D to 4.3
Piralein Aug 25, 2024
493f0ea
Merge pull request #9863 from EastToastLiving/tileset-custom-metadata…
skyace65 Sep 7, 2024
72afe8c
Merge pull request #9834 from Piralein/update_images
skyace65 Sep 7, 2024
2bf43bd
Document reflection probe limitations in compatability renderer
skyace65 Sep 8, 2024
bf4c8bd
Merge pull request #9928 from skyace65/ReflectionProbe
skyace65 Sep 8, 2024
13f05b1
Add note about limitations of macOS export from Windows.
bruvzg Sep 7, 2024
974d1f1
Merge pull request #9921 from bruvzg/win_to_mac_note
skyace65 Sep 9, 2024
d1c0b15
Merge pull request #9920 from godotengine/classref/sync-5675c76
mhilbrunner Sep 9, 2024
ea97a4d
Merge pull request #9918 from Calinou/gdextension-cpp-example-fix-add…
mhilbrunner Sep 9, 2024
459ec69
Merge pull request #9911 from Geometror/unit-testing-signalwatcher-se…
mhilbrunner Sep 9, 2024
5c34036
Update release support timelines: 4.4 ETA, 3.6 is released
akien-mga Sep 9, 2024
9b395eb
Merge pull request #9929 from akien-mga/release-support-3.6
mhilbrunner Sep 9, 2024
3f24c74
Merge pull request #9896 from Brederodes/patch-1
mhilbrunner Sep 9, 2024
00bb144
Merge pull request #9894 from godotengine/dependabot/github_actions/p…
mhilbrunner Sep 10, 2024
de7537a
Fix comments in chroma key example shader
tetrapod00 Sep 10, 2024
48f7902
Merge pull request #9941 from tetrapod00/chroma-shader-syntax
skyace65 Sep 11, 2024
4cda78b
Add 3->4 upgrading information about NDC, light(), and reverse-z
tetrapod00 Sep 10, 2024
85c8a47
Merge pull request #9940 from tetrapod00/shader-upgrading
mhilbrunner Sep 11, 2024
98d6e64
Improve wording
danila-zol Sep 11, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add C# examples to Background loading
Co-authored-by: Raul Santos <[email protected]>
ShawnHardern and raulsntos committed Aug 23, 2024
commit 93fa10d59090079216e6e7d3e9565306f9f7de5a
38 changes: 33 additions & 5 deletions tutorials/io/background_loading.rst
Original file line number Diff line number Diff line change
@@ -48,22 +48,50 @@ The path will be ``"Enemy.tscn"`` which is located at ``res://Enemy.tscn``.

First, we will start a request to load the resource and connect the button:

::
.. tabs::
.. code-tab:: gdscript

const ENEMY_SCENE_PATH : String = "Enemy.tscn"

func _ready():
ResourceLoader.load_threaded_request(ENEMY_SCENE_PATH)
self.pressed.connect(_on_button_pressed)

.. code-tab:: csharp

using Godot;

public partial class MyButton : Button
{
private const string EnemyScenePath = "Enemy.tscn";

public override void _Ready()
{
ResourceLoader.LoadThreadedRequest(EnemyScenePath);
Pressed += OnButtonPressed;
}
}

Now ``_on_button_pressed`` will be called when the button is pressed.
This method will be used to spawn an enemy.

::
.. tabs::
.. code-tab:: gdscript

func _on_button_pressed(): # Button was pressed
# Obtain the resource now that we need it
func _on_button_pressed(): # Button was pressed.
# Obtain the resource now that we need it.
var enemy_scene = ResourceLoader.load_threaded_get(ENEMY_SCENE_PATH)
# Instantiate the enemy scene and add it to the current scene
# Instantiate the enemy scene and add it to the current scene.
var enemy = enemy_scene.instantiate()
add_child(enemy)

.. code-tab:: csharp

private void OnButtonPressed() // Button was pressed.
{
// Obtain the resource now that we need it.
var enemyScene = (PackedScene)ResourceLoader.LoadThreadedGet(EnemyScenePath);
// Instantiate the enemy scene and add it to the current scene.
var enemy = enemyScene.Instantiate();
AddChild(enemy);
}