Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect setup instructions in The profiler #9907

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I just checked and the old language was true for Godot 3.5.3. So we might want to see why the behaviour changed and consider bringing back the ability to start the profiler before running the game

@skyace65 skyace65 added the area:manual Issues and PRs related to the Manual/Tutorials section of the documentation label Sep 5, 2024
@skyace65 skyace65 merged commit a37703e into godotengine:master Sep 5, 2024
1 check passed
@skyace65
Copy link
Contributor

skyace65 commented Sep 5, 2024

Thanks!

@Calinou Calinou deleted the profiler-fix-instructions branch September 16, 2024 21:22
@Calinou
Copy link
Member Author

Calinou commented Sep 16, 2024

Looks good. I just checked and the old language was true for Godot 3.5.3. So we might want to see why the behaviour changed and consider bringing back the ability to start the profiler before running the game

This was changed by godotengine/godot#70151. See also godotengine/godot#72524.

@mhilbrunner
Copy link
Member

Cherry-picked to 4.3 in #10038.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation bug cherrypick:4.2
Projects
None yet
4 participants