Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Profiler and Visual Profiler start/stop state inconsistency #70151

Conversation

stmSi
Copy link
Contributor

@stmSi stmSi commented Dec 16, 2022

Fix: #70143
Fix: #65209

This is my Fix according to my understanding of the issues

  • Start buttons are disabled (grey out) if not running the program (default).
  • Start/Stop buttons are enabled when run the program.
  • Start/Stop buttons are disabled (grey out) when pause the program.
  • Pressing Start buttons will change to Stop and vice visa
  • Stopping the program will reset Stop button to Start and disable the button.

also changes to the Clear button in "Visual Profiler" to be the same behavior with Profiler's Clear button.

@stmSi stmSi requested a review from a team as a code owner December 16, 2022 15:42
@stmSi stmSi force-pushed the fix-profiler-and-visual-profiler-start-stop-state-inconsistency branch 2 times, most recently from b70b78a to e114a26 Compare December 16, 2022 16:02
@clayjohn clayjohn requested a review from a team December 16, 2022 17:54
@clayjohn clayjohn added this to the 4.0 milestone Dec 16, 2022
@stmSi stmSi force-pushed the fix-profiler-and-visual-profiler-start-stop-state-inconsistency branch from e114a26 to 0e91848 Compare December 16, 2022 20:43
@stmSi stmSi force-pushed the fix-profiler-and-visual-profiler-start-stop-state-inconsistency branch 4 times, most recently from cda6843 to bbc8c4f Compare December 17, 2022 07:27
@KoBeWi
Copy link
Member

KoBeWi commented Dec 21, 2022

I think the Start button should still be enabled and when you start in the editor, the profiling should autostart when the project is started. That's how it worked in 3.x at least.

@stmSi
Copy link
Contributor Author

stmSi commented Dec 22, 2022

I think the Start button should still be enabled and when you start in the editor, the profiling should autostart when the project is started. That's how it worked in 3.x at least.

@KoBeWi
In 3.5.2 rc1, profiler doesn't autostart. That's why i disabled Start button at first. I still don't familiar with debugger to implement autostart yet. May be enable by default after we implement autostart?

@stmSi stmSi force-pushed the fix-profiler-and-visual-profiler-start-stop-state-inconsistency branch from bbc8c4f to 9faa089 Compare December 22, 2022 18:13
Copy link
Member

@KoBeWi KoBeWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be enable by default after we implement autostart?

Makes sense.

@stmSi stmSi force-pushed the fix-profiler-and-visual-profiler-start-stop-state-inconsistency branch from 9faa089 to 97e9919 Compare December 23, 2022 01:46
@akien-mga akien-mga merged commit 6ff74f0 into godotengine:master Dec 23, 2022
@akien-mga
Copy link
Member

Thanks!

@stmSi stmSi deleted the fix-profiler-and-visual-profiler-start-stop-state-inconsistency branch December 23, 2022 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Profiler and Visual Profiler start/stop state inconsistency Godot profiler cant start
4 participants