-
-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Profiler and Visual Profiler start/stop state inconsistency #70151
Fix: Profiler and Visual Profiler start/stop state inconsistency #70151
Conversation
b70b78a
to
e114a26
Compare
e114a26
to
0e91848
Compare
cda6843
to
bbc8c4f
Compare
I think the Start button should still be enabled and when you start in the editor, the profiling should autostart when the project is started. That's how it worked in 3.x at least. |
@KoBeWi |
bbc8c4f
to
9faa089
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May be enable by default after we implement autostart?
Makes sense.
9faa089
to
97e9919
Compare
Thanks! |
Fix: #70143
Fix: #65209
This is my Fix according to my understanding of the issues
also changes to the Clear button in "Visual Profiler" to be the same behavior with Profiler's Clear button.