Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add info about layer mask exporting to physics_introduction.rst #10242

Merged
merged 4 commits into from
Nov 17, 2024

Conversation

notPelf
Copy link
Contributor

@notPelf notPelf commented Nov 10, 2024

The docs page for raycasting provides a link to the physics introduction page for how to set a collision mask on a raycast created in code. The physics introduction page does not mention export annotations for exporting a collision mask. This pull request adds a brief bit about exporting layer masks, and links to the export annotation docs page.

The docs page for raycasting provides a link to the physics introduction page for how to set a collision mask on a raycast created in code. The physics introduction page does not mention export annotations for exporting a collision mask. This pull request adds a brief bit about exporting layer masks, and links to the export annotation docs.
Copy link
Contributor

@tetrapod00 tetrapod00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea but needs a change so the cross-reference link works

tutorials/physics/physics_introduction.rst Outdated Show resolved Hide resolved
notPelf and others added 2 commits November 10, 2024 17:17
Update cross-page link to use correct anchor format

Co-authored-by: tetrapod <[email protected]>
Added anchor for exporting bit flags section
@tetrapod00 tetrapod00 added area:manual Issues and PRs related to the Manual/Tutorials section of the documentation topic:physics cherrypick:4.3 labels Nov 14, 2024
@mhilbrunner mhilbrunner merged commit 8835289 into godotengine:4.3 Nov 17, 2024
1 check passed
@mhilbrunner
Copy link
Member

Thanks, merged! For future PRs, please note changes should go against the master branch by default unless they only apply to a specific old version. We'll handle cherrypicking the change to old versions.

mhilbrunner pushed a commit that referenced this pull request Nov 17, 2024
* Update physics_introduction.rst

The docs page for raycasting provides a link to the physics introduction page for how to set a collision mask on a raycast created in code. The physics introduction page does not mention export annotations for exporting a collision mask. This pull request adds a brief bit about exporting layer masks, and links to the export annotation docs.

---------

Co-authored-by: tetrapod <[email protected]>
mhilbrunner added a commit that referenced this pull request Nov 17, 2024
Cherrypick #10242 (Add info about layer mask exporting to physics_introduction) to master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation enhancement topic:physics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants