-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize renderer names and terms #10183
Standardize renderer names and terms #10183
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just needs a few fixes.
contributing/development/core_and_modules/internal_rendering_architecture.rst
Outdated
Show resolved
Hide resolved
contributing/development/core_and_modules/internal_rendering_architecture.rst
Outdated
Show resolved
Hide resolved
contributing/development/core_and_modules/internal_rendering_architecture.rst
Outdated
Show resolved
Hide resolved
770aca8
to
5c712cd
Compare
Removed all references to "Forward Mobile" from the manual, except for a single note on the Internal rendering architecture page that says "Forward Mobile" is the internal name. I believe the original issue and the terminology used was approved by Calinou and Clay, but we should wait to merge this until one of them gives it at least a quick look. |
5c712cd
to
9165839
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs a rebase, otherwise looks good to me.
9165839
to
1aaadff
Compare
Rebased, but this still does need at least a cursory review from someone in rendering |
1aaadff
to
f2ce3ee
Compare
Thanks! |
I don't really think this one is worth the effort to cherrypick to 4.3. Removing the label. |
Part of #10139. (Doesn't close, because some changes must be made in the class ref still.)
See also godotengine/godot#98747, godotengine/godot#98744.
Standardizes terms for renderers/rendering methods, rendering drivers, and "rendering backends".
New standards, for user-facing docs:
+
is not a valid symbol.gl_compatibility
is how it is exposed in the project settings.This PR changes:
Since the existing terms are nonstandardized, I probably missed a few instances.