-
-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize terms for renderers in error strings #98747
Standardize terms for renderers in error strings #98747
Conversation
I think completing all the translation changes rather than waiting for some future version is probably best. |
Translated strings changed. I left them in a separate commit until the decision is made. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These comments are mostly unrelated to the PR itself, they're more-so tweaks while we're at it. The related documentation PR is favoured, regardless of the final term chosen for these.
servers/rendering/renderer_rd/forward_mobile/scene_shader_forward_mobile.cpp
Outdated
Show resolved
Hide resolved
Removed most review requests as the internal logic is not affected, this PR mostly touches the printed messages. |
Use "Forward+", "Mobile", "Compatibility", and "renderer" or "rendering method".
cfdd788
to
899f515
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but should be approved by Rendering.
Thanks! |
Closes godotengine/godot-docs#10139 (after the other two PRs are merged).
See also #98744, godotengine/godot-docs#10183.
Change instances where a renderer/rendering method is called a "backend". Change instances of "GL Compatibility" to "Compatibility", since that is what appears in the editor UI.
Only strings that are not
RTR
orTTR
were changed. There are still some ambiguous usages of "backend" in those strings, but I didn't think the translation churn was worth the change.