Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize terms for renderers in error strings #98747

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

tetrapod00
Copy link
Contributor

Closes godotengine/godot-docs#10139 (after the other two PRs are merged).
See also #98744, godotengine/godot-docs#10183.

Change instances where a renderer/rendering method is called a "backend". Change instances of "GL Compatibility" to "Compatibility", since that is what appears in the editor UI.

Only strings that are not RTR or TTR were changed. There are still some ambiguous usages of "backend" in those strings, but I didn't think the translation churn was worth the change.

@fire
Copy link
Member

fire commented Nov 2, 2024

I think completing all the translation changes rather than waiting for some future version is probably best.

@tetrapod00 tetrapod00 requested review from a team as code owners November 2, 2024 01:38
@tetrapod00
Copy link
Contributor Author

Translated strings changed. I left them in a separate commit until the decision is made.

Copy link
Contributor

@Mickeon Mickeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These comments are mostly unrelated to the PR itself, they're more-so tweaks while we're at it. The related documentation PR is favoured, regardless of the final term chosen for these.

drivers/gles3/rasterizer_scene_gles3.cpp Outdated Show resolved Hide resolved
drivers/gles3/storage/material_storage.cpp Outdated Show resolved Hide resolved
drivers/gles3/storage/material_storage.cpp Outdated Show resolved Hide resolved
drivers/gles3/storage/particles_storage.cpp Show resolved Hide resolved
editor/import/resource_importer_shader_file.cpp Outdated Show resolved Hide resolved
@Mickeon Mickeon modified the milestones: 4.x, 4.4 Nov 10, 2024
@Mickeon Mickeon removed request for a team November 10, 2024 17:21
@Mickeon
Copy link
Contributor

Mickeon commented Nov 10, 2024

Removed most review requests as the internal logic is not affected, this PR mostly touches the printed messages.

Use "Forward+", "Mobile", "Compatibility", and "renderer" or "rendering method".
@tetrapod00 tetrapod00 force-pushed the standardize-renderer-strings branch from cfdd788 to 899f515 Compare November 10, 2024 21:31
Copy link
Member

@mhilbrunner mhilbrunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but should be approved by Rendering.

@Repiteo Repiteo merged commit 9ecdeb3 into godotengine:master Dec 13, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Dec 13, 2024

Thanks!

@tetrapod00 tetrapod00 deleted the standardize-renderer-strings branch December 13, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standardize names for the rendering methods / renderers
7 participants