Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Antialiasing comparison table, remove redundant MSAA limitations section #10167

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

tetrapod00
Copy link
Contributor

Closes #10154.

Removes a redundant section on MSAA (which, at the time of writing, apparently functioned as general antialiasing documentation). Adds a new comparison table to the 3D antialiasing page.

Information in the table is taken from the rest of the page. There's a chance that some of the information in the rest of the page will need to be updated, too.

I don't believe that a redirect or stub section on 3D rendering limitations is needed in this case.

In the table, ❌✔️ are used for renderer support, and 🔴🟡🟢 are used for comparison of features (because the ⚠️ emoji is not a good match for "medium performance", for example). Table renders like this:
msedge_VuN7vNQxb2

Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@mhilbrunner mhilbrunner added enhancement topic:rendering area:manual Issues and PRs related to the Manual/Tutorials section of the documentation labels Oct 30, 2024
@mhilbrunner
Copy link
Member

Looks good to me too, and if Clay approves, may as well merge :) Thanks!

@mhilbrunner mhilbrunner merged commit bd00434 into godotengine:master Oct 30, 2024
1 check passed
@tetrapod00 tetrapod00 deleted the redundant-msaa branch October 30, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation enhancement topic:rendering topic:3d
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove redundant section 3D rendering limitations/MSAA, add any missing information to 3D antialiasing/MSAA
4 participants