Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak SSRL performance cost in 3D antialiasing comparison table #10223

Merged

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Nov 7, 2024

The screen-space roughness limiter's performance cost is very low compared to other antialiasing methods (typically in the same ballpark as FXAA).

The screen-space roughness limiter's performance cost is very low
compared to other antialiasing methods (typically in the same
ballpark as FXAA).
@Calinou Calinou added enhancement topic:rendering topic:3d area:manual Issues and PRs related to the Manual/Tutorials section of the documentation labels Nov 7, 2024
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's right. I would say even lower than FXAA

@tetrapod00
Copy link
Contributor

Thanks. The current SSRL body text also calls the cost "small", so the table now matches the current description.

(The cost was called "moderate" in the removed MSAA limitations section, so I probably used that as the source for "medium cost" instead of the more up-to-date info in the AA page itself)

@mhilbrunner mhilbrunner merged commit c181d61 into godotengine:master Nov 7, 2024
1 check passed
@mhilbrunner
Copy link
Member

Thanks!

@Calinou Calinou deleted the antialiasing-table-ssrl-tweak-cost branch November 8, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation enhancement topic:rendering topic:3d
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants