Fix review code comment avatar alignment

[henrygoodman]

Fixes #33017

Avatar should only have offset if the Comment has Content or Attachment to align with the speech bubble:

Otherwise, it should align with the timeline event badge.

Issue occurs when a comment is posted with Review.CodeComments but no Content.
Can be fixed by simply checking Content exists

Before:

After:

[henrygoodman]

Sorry, did not see approval before force push, just small update for redundancy (functionally same I think)

ead17bb#commitcomment-150794153

[wxiaoguang]

I do no think this change is right complete, is it clear that why it doesn't match the CodeComments below?

Are all edge cases covered?

[henrygoodman]

Are all edge cases covered?

I think cases needing to consider are combination of Review.Content and Review.CodeComments. Unsure if any other cases to test.

1. Review.Content and Review.CodeComments

2. not Review.Content and Review.CodeComments

3. Review.Content and not Review.CodeComments

4. not Review.Content and not Review.CodeComments

[wxiaoguang]

I can see there is still an edge: leave a review comment with code comment, and edit the review comment to make it empty

[wxiaoguang]

One more thing, by reading code, .Review.Content is not right here.

The rendered content is always .Content (issue comment), .Review.Content is never used.

For example, if you edit the review's content and save, the comment table's Content gets udpated, but the review table's Content doesn't, it is still the out-dated old content (never used).

[wxiaoguang]

Maybe it should be as simple as:

{{if or .Content .Attachments}}

Because the "review" doesn't affect the "Content" rendering.

[henrygoodman]

Maybe it should be as simple as:

{{if or .Content .Attachments}}

Because the "review" doesn't affect the "Content" rendering.

Good catch, thankyou. I guess Review and Review.Content must get transitively added at same time when Content is added but I guess if removing, it doesnt update the Review.Content. (so just checking Content is sufficient). Probably should have looked into the hierarchy more.

Tested and seems fine for edge cases