Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor comment history and fix content edit #33018

Merged
merged 1 commit into from
Dec 28, 2024

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Dec 28, 2024

And fix a regression bug for comment content editing.

Now 11 "import jquery" files left

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 28, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 28, 2024
@wxiaoguang wxiaoguang added type/refactoring Existing code has been cleaned up. There should be no new functionality. and removed modifies/frontend labels Dec 28, 2024
@wxiaoguang wxiaoguang force-pushed the refacotor-issue-content branch from cd3ddbe to 4c02b58 Compare December 28, 2024 06:21
@wxiaoguang wxiaoguang added this to the 1.24.0 milestone Dec 28, 2024
@wxiaoguang wxiaoguang force-pushed the refacotor-issue-content branch from 4c02b58 to 8639203 Compare December 28, 2024 06:35
@github-actions github-actions bot added the modifies/templates This PR modifies the template files label Dec 28, 2024
@wxiaoguang wxiaoguang changed the title Refactor repo-issue-content.ts and remove jquery import Refactor comment history and content edit Dec 28, 2024
@wxiaoguang wxiaoguang force-pushed the refacotor-issue-content branch from 8639203 to 0aa31dd Compare December 28, 2024 06:36
@wxiaoguang wxiaoguang added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Dec 28, 2024
@wxiaoguang wxiaoguang changed the title Refactor comment history and content edit Refactor comment history and fixcontent edit Dec 28, 2024
@wxiaoguang wxiaoguang changed the title Refactor comment history and fixcontent edit Refactor comment history and fix content edit Dec 28, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 28, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 28, 2024
@wxiaoguang wxiaoguang merged commit 3d3ece3 into go-gitea:main Dec 28, 2024
26 checks passed
@wxiaoguang wxiaoguang deleted the refacotor-issue-content branch December 28, 2024 11:26
zjjhot added a commit to zjjhot/gitea that referenced this pull request Dec 30, 2024
* giteaofficial/main:
  Refactor pagination (go-gitea#33037)
  Test webhook email (go-gitea#33033)
  Fix review code comment avatar alignment (go-gitea#33031)
  Fix templating in pull request comparison (go-gitea#33025)
  Refactor tests (go-gitea#33021)
  [skip ci] Updated translations via Crowdin
  always show assignees on right (go-gitea#33006)
  fix toggle commit body button ui when latest commit message is long (go-gitea#32997)
  Fix and/or comment some legacy CSS problems (go-gitea#33015)
  Refactor comment history and fix content edit (go-gitea#33018)
  Fix bug on activities (go-gitea#33008)
  Refactor arch route handlers (go-gitea#32993)
  fix scoped label ui when contains emoji (go-gitea#33007)
  [skip ci] Updated translations via Crowdin
  De-emphasize signed commits (go-gitea#31160)
  Fix eslint (go-gitea#33002)
  Fix Agit pull request permission check (go-gitea#32999)
  Support for email addresses containing uppercase characters when activating user account (go-gitea#32998)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/frontend modifies/templates This PR modifies the template files size/M Denotes a PR that changes 30-99 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants