Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor arch route handlers #32993

Merged
merged 5 commits into from
Dec 28, 2024
Merged

Refactor arch route handlers #32993

merged 5 commits into from
Dec 28, 2024

Conversation

wxiaoguang
Copy link
Contributor

No description provided.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 26, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 26, 2024
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Dec 26, 2024
@wxiaoguang wxiaoguang mentioned this pull request Dec 26, 2024
Merged
@wxiaoguang wxiaoguang added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Dec 26, 2024
@wxiaoguang wxiaoguang added this to the 1.24.0 milestone Dec 26, 2024
@KN4CK3R
Copy link
Member

KN4CK3R commented Dec 26, 2024

Is it possible to replace <...> with {...} to keep the format of the usual chi parameters?

@wxiaoguang
Copy link
Contributor Author

Is it possible to replace <...> with {...} to keep the format of the usual chi parameters?

Nope, it is intentionally designed to distinguish it from the chi router's path parameter. Their behaviors are totally different.

@KN4CK3R
Copy link
Member

KN4CK3R commented Dec 26, 2024

Is it possible to mix <...> and {...} in a MatchPath call? If not there are less reasons to distinguish between them.

@wxiaoguang
Copy link
Contributor Author

wxiaoguang commented Dec 26, 2024 •
edited
Loading

Is it possible to mix <...> and {...} in a MatchPath call? If not there are less reasons to distinguish between them.

No, the reasons are strong 6ba3818

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 26, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 28, 2024
@wxiaoguang wxiaoguang enabled auto-merge (squash) December 28, 2024 03:06
@wxiaoguang wxiaoguang merged commit e435b19 into go-gitea:main Dec 28, 2024
26 checks passed
@wxiaoguang wxiaoguang deleted the refactor-route branch December 28, 2024 03:34
zjjhot added a commit to zjjhot/gitea that referenced this pull request Dec 30, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
dcb2993 
* giteaofficial/main:
  Refactor pagination (go-gitea#33037)
  Test webhook email (go-gitea#33033)
  Fix review code comment avatar alignment (go-gitea#33031)
  Fix templating in pull request comparison (go-gitea#33025)
  Refactor tests (go-gitea#33021)
  [skip ci] Updated translations via Crowdin
  always show assignees on right (go-gitea#33006)
  fix toggle commit body button ui when latest commit message is long (go-gitea#32997)
  Fix and/or comment some legacy CSS problems (go-gitea#33015)
  Refactor comment history and fix content edit (go-gitea#33018)
  Fix bug on activities (go-gitea#33008)
  Refactor arch route handlers (go-gitea#32993)
  fix scoped label ui when contains emoji (go-gitea#33007)
  [skip ci] Updated translations via Crowdin
  De-emphasize signed commits (go-gitea#31160)
  Fix eslint (go-gitea#33002)
  Fix Agit pull request permission check (go-gitea#32999)
  Support for email addresses containing uppercase characters when activating user account (go-gitea#32998)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zettat123 Zettat123 Zettat123 approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.
5 participants
@wxiaoguang @KN4CK3R @lunny @Zettat123 @GiteaBot