Respect the REGISTER_MANUAL_CONFIRM setting when registering via OIDC #24035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gary Moon <[email protected]>
silverwind
approved these changes
Apr 23, 2023
GiteaBot
added
the
lgtm/need 1
pull-request-size
bot
added
the
size/XS
silverwind
added
topic/authentication
type/bug
and removed
size/XS
|
@kdumontnu care to review? |
We try to avoid the conflict of interest since we work together at AllSpice. |
wxiaoguang
approved these changes
Apr 24, 2023
GiteaBot
added
lgtm/done
pull-request-size
bot
added
the
size/XS
yardenshoham
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
wxiaoguang
added
the
outdated/backport/v1.19
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Apr 25, 2023
…go-gitea#24035) This change prevents Gitea from bypassing the manual approval process for newly registered users when OIDC is used. - Resolves go-gitea#23392 Signed-off-by: Gary Moon <[email protected]>
silverwind
pushed a commit
that referenced
this pull request
Apr 25, 2023
…#24035) (#24333) Backport #24035 by @garymoon This change prevents Gitea from bypassing the manual approval process for newly registered users when OIDC is used. - Resolves #23392 Signed-off-by: Gary Moon <[email protected]> Co-authored-by: Gary Moon <[email protected]>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Apr 26, 2023
* giteaofficial/main: Fix broken clone script on an empty archived repo (go-gitea#24339) Improve RSS (go-gitea#24335) Automatically select the org when click create repo from org dashboard (go-gitea#24325) on schedule on schedule switch to use Actions from drone for cron (go-gitea#24314) [skip ci] Updated translations via Crowdin Restore bold on repolist (go-gitea#24337) Fix template function DateTime (go-gitea#24317) Fix incorrect CORS response in Http Git handler (go-gitea#24303) Updated upgrade script that is informing user that Gitea service has to be running in order to upgrade it (go-gitea#24260) Add tags list for repos whose release setting is disabled (go-gitea#23465) Refactor config provider (go-gitea#24245) Add RSS Feeds for branches and files (go-gitea#22719) Make SVG in dropdown menu have the same margin-right as IMG (go-gitea#24316) Respect the REGISTER_MANUAL_CONFIRM setting when registering via OIDC (go-gitea#24035)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change prevents Gitea from bypassing the manual approval process for newly registered users when OIDC is used.