Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect the REGISTER_MANUAL_CONFIRM setting when registering via OIDC (#24035) #24333

Merged
merged 3 commits into from
Apr 25, 2023
Merged

Respect the REGISTER_MANUAL_CONFIRM setting when registering via OIDC (#24035) #24333

merged 3 commits into from
Apr 25, 2023

Conversation

GiteaBot
Copy link
Collaborator

Backport #24035 by @garymoon

This change prevents Gitea from bypassing the manual approval process for newly registered users when OIDC is used.

@garymoon @GiteaBot
Respect the REGISTER_MANUAL_CONFIRM setting when registering via OIDC (…
0b95d94 
…go-gitea#24035)

This change prevents Gitea from bypassing the manual approval process
for newly registered users when OIDC is used.

- Resolves go-gitea#23392

Signed-off-by: Gary Moon <[email protected]>
@GiteaBot GiteaBot added type/bug topic/authentication lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 25, 2023
@GiteaBot GiteaBot added this to the 1.19.2 milestone Apr 25, 2023
@GiteaBot GiteaBot requested a review from silverwind April 25, 2023 14:08
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 25, 2023
@GiteaBot GiteaBot requested a review from wxiaoguang April 25, 2023 14:08
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 25, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 25, 2023
@silverwind silverwind enabled auto-merge (squash) April 25, 2023 14:49
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 25, 2023
@silverwind silverwind merged commit 1bbbeb2 into go-gitea:release/v1.19 Apr 25, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 25, 2023
@techknowlogick techknowlogick deleted the backport-24035-v1.19 branch April 26, 2023 00:26
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jolheiser jolheiser jolheiser approved these changes

@yardenshoham yardenshoham yardenshoham approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. topic/authentication type/bug
Projects
None yet
Milestone
1.19.2
Development

Successfully merging this pull request may close these issues.
7 participants
@GiteaBot @silverwind @wxiaoguang @yardenshoham @jolheiser @lunny @garymoon