Fix incorrect CORS response in Http Git handler #24303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/M
wxiaoguang
force-pushed
the
fix-http-git-cors
branch
from
5389c21
to
0e40fa3
Compare
wxiaoguang
force-pushed
the
fix-http-git-cors
branch
from
0e40fa3
to
86a8368
Compare
silverwind
approved these changes
Apr 24, 2023
GiteaBot
added
the
lgtm/need 1
|
I think there is at least one more CORS handler somewhere in the code base, at least there are two distinct config options for CORS headers, but doesn't need to be handled in this PR. |
There are for different purpose, so can't be merged. |
wolfogre
approved these changes
Apr 25, 2023
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
5 tasks
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Apr 26, 2023
* giteaofficial/main: Fix broken clone script on an empty archived repo (go-gitea#24339) Improve RSS (go-gitea#24335) Automatically select the org when click create repo from org dashboard (go-gitea#24325) on schedule on schedule switch to use Actions from drone for cron (go-gitea#24314) [skip ci] Updated translations via Crowdin Restore bold on repolist (go-gitea#24337) Fix template function DateTime (go-gitea#24317) Fix incorrect CORS response in Http Git handler (go-gitea#24303) Updated upgrade script that is informing user that Gitea service has to be running in order to upgrade it (go-gitea#24260) Add tags list for repos whose release setting is disabled (go-gitea#23465) Refactor config provider (go-gitea#24245) Add RSS Feeds for branches and files (go-gitea#22719) Make SVG in dropdown menu have the same margin-right as IMG (go-gitea#24316) Respect the REGISTER_MANUAL_CONFIRM setting when registering via OIDC (go-gitea#24035)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the general
cors.Handlerfor CORS