Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⬆️ Combined updates #884

Merged
merged 6 commits into from
Oct 24, 2021
Merged

⬆️ Combined updates #884

merged 6 commits into from
Oct 24, 2021

Conversation

s-weigand
Copy link
Member

@s-weigand s-weigand commented Oct 24, 2021 •
edited by jsnel
Loading

Combines the PRs:

To save CI time.

Checklist

  • ✔️ Passing the tests (mandatory for all PR's)

closes #865
closes #863
closes #761
closes #845
closes #850

dependabot bot and others added 6 commits October 24, 2021 15:29
@dependabot @s-weigand
Bump actions/github-script from 4 to 5
77159d8 
Bumps [actions/github-script](https://github.com/actions/github-script) from 4 to 5.
- [Release notes](https://github.com/actions/github-script/releases)
- [Commits](actions/github-script@v4...v5)

---
updated-dependencies:
- dependency-name: actions/github-script
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@s-weigand
🚇 🩹 Adjust binder badge creation to github-script v5
ea49545
@dependabot @s-weigand
Bump click from 8.0.1 to 8.0.3
85d1ec2 
Bumps [click](https://github.com/pallets/click) from 8.0.1 to 8.0.3.
- [Release notes](https://github.com/pallets/click/releases)
- [Changelog](https://github.com/pallets/click/blob/main/CHANGES.rst)
- [Commits](pallets/click@8.0.1...8.0.3)

---
updated-dependencies:
- dependency-name: click
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@s-weigand
Bump rich from 10.9.0 to 10.12.0
df2f15e 
Bumps [rich](https://github.com/willmcgugan/rich) from 10.9.0 to 10.12.0.
- [Release notes](https://github.com/willmcgugan/rich/releases)
- [Changelog](https://github.com/willmcgugan/rich/blob/master/CHANGELOG.md)
- [Commits](Textualize/rich@v10.9.0...v10.12.0)

---
updated-dependencies:
- dependency-name: rich
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @s-weigand
Bump pyyaml from 5.4.1 to 6.0
370a65c 
Bumps [pyyaml](https://github.com/yaml/pyyaml) from 5.4.1 to 6.0.
- [Release notes](https://github.com/yaml/pyyaml/releases)
- [Changelog](https://github.com/yaml/pyyaml/blob/master/CHANGES)
- [Commits](yaml/pyyaml@5.4.1...6.0)

---
updated-dependencies:
- dependency-name: pyyaml
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@s-weigand
Bump scipy from 1.7.0 to 1.7.1
79490cb 
Bumps [scipy](https://github.com/scipy/scipy) from 1.7.0 to 1.7.1.
- [Release notes](https://github.com/scipy/scipy/releases)
- [Commits](scipy/scipy@v1.7.0...v1.7.1)

---
updated-dependencies:
- dependency-name: scipy
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@s-weigand s-weigand requested a review from a team as a code owner October 24, 2021 13:34
@github-actions
Copy link
Contributor

Binder 👈 Launch a binder notebook on branch s-weigand/pyglotaran/combined-updates

@sonarcloud
Copy link

sonarcloud bot commented Oct 24, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.7% 0.7% Duplication

@github-actions
Copy link
Contributor

Benchmark is done. Checkout the benchmark result page.
Benchmark differences below 5% might be due to CI noise.

Benchmark diff v0.4.1 vs. main

Parametrized benchmark signatures:

BenchmarkOptimize.time_optimize(index_dependent, grouped, weight)

All benchmarks:

       before           after         ratio
     [21ba272a]       [79490cbf]
     <v0.4.1>                   
+      54.5±0.7ms         61.6±1ms     1.13  BenchmarkOptimize.time_optimize(False, False, False)
-         325±8ms        67.6±10ms     0.21  BenchmarkOptimize.time_optimize(False, False, True)
         75.8±1ms         61.7±4ms    ~0.81  BenchmarkOptimize.time_optimize(False, True, False)
         77.1±1ms         68.5±8ms    ~0.89  BenchmarkOptimize.time_optimize(False, True, True)
+      53.3±0.4ms         73.7±4ms     1.38  BenchmarkOptimize.time_optimize(True, False, False)
-         329±8ms        78.5±20ms     0.24  BenchmarkOptimize.time_optimize(True, False, True)
         75.4±2ms         74.6±1ms     0.99  BenchmarkOptimize.time_optimize(True, True, False)
         79.3±3ms        84.7±40ms     1.07  BenchmarkOptimize.time_optimize(True, True, True)
             193M             193M     1.00  IntegrationTwoDatasets.peakmem_optimize
-      4.92±0.01s        1.83±0.1s     0.37  IntegrationTwoDatasets.time_optimize
Benchmark diff main vs. PR

Parametrized benchmark signatures:

BenchmarkOptimize.time_optimize(index_dependent, grouped, weight)

All benchmarks:

       before           after         ratio
     [5cdf0234]       [79490cbf]
       62.4±0.9ms         61.6±1ms     0.99  BenchmarkOptimize.time_optimize(False, False, False)
         68.6±1ms        67.6±10ms     0.98  BenchmarkOptimize.time_optimize(False, False, True)
         61.8±1ms         61.7±4ms     1.00  BenchmarkOptimize.time_optimize(False, True, False)
         66.9±7ms         68.5±8ms     1.02  BenchmarkOptimize.time_optimize(False, True, True)
       74.1±0.8ms         73.7±4ms     1.00  BenchmarkOptimize.time_optimize(True, False, False)
         105±50ms        78.5±20ms    ~0.75  BenchmarkOptimize.time_optimize(True, False, True)
         74.7±2ms         74.6±1ms     1.00  BenchmarkOptimize.time_optimize(True, True, False)
        82.2±50ms        84.7±40ms     1.03  BenchmarkOptimize.time_optimize(True, True, True)
             193M             193M     1.00  IntegrationTwoDatasets.peakmem_optimize
       1.96±0.08s        1.83±0.1s     0.93  IntegrationTwoDatasets.time_optimize

@codecov
Copy link

codecov bot commented Oct 24, 2021 •
edited
Loading

Codecov Report

Merging #884 (79490cb) into main (5cdf023) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #884   +/-   ##
=====================================
  Coverage   84.7%   84.7%           
=====================================
  Files         81      81           
  Lines       4596    4596           
  Branches     849     849           
=====================================
  Hits        3897    3897           
  Misses       558     558           
  Partials     141     141

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cdf023...79490cb. Read the comment docs.

jsnel
jsnel approved these changes Oct 24, 2021
View reviewed changes
Copy link
Member

@jsnel jsnel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 ⬆️

@jsnel jsnel merged commit d05c042 into glotaran:main Oct 24, 2021
@jsnel jsnel deleted the combined-updates branch October 24, 2021 14:30
@s-weigand s-weigand mentioned this pull request Nov 17, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsnel jsnel jsnel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@s-weigand @jsnel