Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump actions/github-script from 4 to 5 #845

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 1, 2021

Bumps actions/github-script from 4 to 5.

Release notes

Sourced from actions/github-script's releases.

v5.0.0

What's Changed

Full Changelog: actions/github-script@v4.1.1...v5.0.0

v4.1.1

What's Changed

Full Changelog: actions/github-script@v4.1.0...v4.1.1

v4.1.0

What's Changed

New Contributors

Full Changelog: actions/github-script@v4.0.2...v4.1.0

Update @​actions/core package

This release updates the @actions/core package to 1.2.7 - actions/github-script#137

Fix "require" search path

Previously, the wrapped require searched the existing module.paths and then process.cwd(). We now only search process.cwd(). See actions/github-script#136 for details.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from a team as a code owner October 1, 2021 16:03
@dependabot dependabot bot added dependencies Pull requests that update a dependency file github_actions Pull requests that update Github_actions code labels Oct 1, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2021

Binder 👈 Launch a binder notebook on branch glotaran/pyglotaran/dependabot/github_actions/actions/github-script-5

@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2021

Benchmark is done. Checkout the benchmark result page.
Benchmark differences below 5% might be due to CI noise.

Benchmark diff v0.4.1 vs. main

Parametrized benchmark signatures:

BenchmarkOptimize.time_optimize(index_dependent, grouped, weight)

All benchmarks:

       before           after         ratio
     [21ba272a]       [ce79b650]
     <v0.4.1>                   
+      45.7±0.1ms       52.4±0.3ms     1.15  BenchmarkOptimize.time_optimize(False, False, False)
-       279±0.7ms         56.6±1ms     0.20  BenchmarkOptimize.time_optimize(False, False, True)
-      64.2±0.4ms       52.4±0.3ms     0.82  BenchmarkOptimize.time_optimize(False, True, False)
-      66.2±0.1ms       55.9±0.7ms     0.84  BenchmarkOptimize.time_optimize(False, True, True)
+      46.0±0.2ms       62.9±0.2ms     1.37  BenchmarkOptimize.time_optimize(True, False, False)
-       280±0.9ms        67.5±30ms     0.24  BenchmarkOptimize.time_optimize(True, False, True)
       64.3±0.3ms       63.3±0.4ms     0.99  BenchmarkOptimize.time_optimize(True, True, False)
       66.2±0.3ms        89.5±40ms    ~1.35  BenchmarkOptimize.time_optimize(True, True, True)
             189M             195M     1.03  IntegrationTwoDatasets.peakmem_optimize
-      4.25±0.04s       1.51±0.07s     0.35  IntegrationTwoDatasets.time_optimize

Benchmark diff main vs. PR

Parametrized benchmark signatures:

BenchmarkOptimize.time_optimize(index_dependent, grouped, weight)

All benchmarks:

       before           after         ratio
     [3a39bfee]       [ce79b650]
       52.3±0.3ms       52.4±0.3ms     1.00  BenchmarkOptimize.time_optimize(False, False, False)
         56.5±9ms         56.6±1ms     1.00  BenchmarkOptimize.time_optimize(False, False, True)
       52.1±0.2ms       52.4±0.3ms     1.01  BenchmarkOptimize.time_optimize(False, True, False)
         56.7±2ms       55.9±0.7ms     0.99  BenchmarkOptimize.time_optimize(False, True, True)
       63.1±0.3ms       62.9±0.2ms     1.00  BenchmarkOptimize.time_optimize(True, False, False)
        67.4±40ms        67.5±30ms     1.00  BenchmarkOptimize.time_optimize(True, False, True)
       62.9±0.3ms       63.3±0.4ms     1.01  BenchmarkOptimize.time_optimize(True, True, False)
        68.1±30ms        89.5±40ms    ~1.32  BenchmarkOptimize.time_optimize(True, True, True)
             192M             195M     1.01  IntegrationTwoDatasets.peakmem_optimize
       1.52±0.07s       1.51±0.07s     0.99  IntegrationTwoDatasets.time_optimize

@codecov
Copy link

codecov bot commented Oct 1, 2021

Codecov Report

Merging #845 (ce79b65) into main (3a39bfe) will not change coverage.
The diff coverage is n/a.

❗ Current head ce79b65 differs from pull request most recent head 221e51b. Consider uploading reports for the commit 221e51b to get more accurate results
Impacted file tree graph

@@          Coverage Diff          @@
##            main    #845   +/-   ##
=====================================
  Coverage   84.7%   84.7%           
=====================================
  Files         81      81           
  Lines       4596    4596           
  Branches     849     849           
=====================================
  Hits        3897    3897           
  Misses       558     558           
  Partials     141     141           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cdf023...221e51b. Read the comment docs.

s-weigand
s-weigand previously approved these changes Oct 3, 2021
Copy link
Member

@s-weigand s-weigand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@s-weigand s-weigand force-pushed the dependabot/github_actions/actions/github-script-5 branch 2 times, most recently from 7d0cd3f to ca94b73 Compare October 13, 2021 02:09
@s-weigand s-weigand force-pushed the dependabot/github_actions/actions/github-script-5 branch from ca94b73 to ce79b65 Compare October 24, 2021 12:36
s-weigand
s-weigand previously approved these changes Oct 24, 2021
dependabot bot and others added 2 commits October 24, 2021 15:26
Bumps [actions/github-script](https://github.com/actions/github-script) from 4 to 5.
- [Release notes](https://github.com/actions/github-script/releases)
- [Commits](actions/github-script@v4...v5)

---
updated-dependencies:
- dependency-name: actions/github-script
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@s-weigand s-weigand force-pushed the dependabot/github_actions/actions/github-script-5 branch from ce79b65 to 221e51b Compare October 24, 2021 13:27
@s-weigand s-weigand mentioned this pull request Oct 24, 2021
1 task
@sonarcloud
Copy link

sonarcloud bot commented Oct 24, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jsnel jsnel closed this in #884 Oct 24, 2021
jsnel pushed a commit that referenced this pull request Oct 24, 2021
⬆️ Batch updating dependencies

- Bump click from 8.0.1 to 8.0.3 #865
- Bump pyyaml from 5.4.1 to 6.0 #863
- Bump scipy from 1.7.0 to 1.7.1 #761
- Bump actions/github-script from 4 to 5 #845
- Bump rich from 10.9.0 to 10.12.0 #850
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 24, 2021

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/github_actions/actions/github-script-5 branch October 24, 2021 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file github_actions Pull requests that update Github_actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant