Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pod6 #1185

Closed
wants to merge 4 commits into from
Closed

Add pod6 #1185

wants to merge 4 commits into from

Conversation

Tyil
Copy link

@Tyil Tyil commented Mar 29, 2018

I'm trying to make this work with Perl 6 Pod in order to close Raku/doc#167. I've made a PR to Linguist to make Linguist recognize Pod6 as a language. This PR Works On My Machine™, though it probably needs some work to be production ready.

On this repository I've been having more troubles, though. For now, I've been running my tests with

ruby -I ../linguist/lib/ -I lib test/markup_test.rb 

and the Pod6 test keeps failing, even after I took the exact output from the pod62html command and put it into my test

./lib/github/commands/pod62html < test/markups/README.pod6 > test/markups/README.pod6.html

I'm at a slight loss here, and was hoping I could get some advice in here to get me going again.

@JJ
Copy link
Contributor

JJ commented Mar 29, 2018

Thanks a lot for your help, but this was done already in #1173, which is waiting on the queue. Maybe this will help the maintainers of the repo see how important this is to our community...

@lildude
Copy link
Member

lildude commented May 30, 2018

As detailed at github-linguist/linguist#4083 (comment), I've had to revert the addition of Pod 6 support to Linguist as we can't roll it out to GitHub.com until markup has support to render Pod 6 files. A Linguist and markup release with support for Pod 6 will need to be made around about the same time (possibly even the same PR) to ensure users aren't left scratching their heads wondering why one pod file suddenly renders correctly and another doesn't (because it's now being detected as Pod 6 instead of Pod).

github-linguist/linguist#4149 is the new Linguist PR that adds back Pod 6 support and remains dependant on a similar markup PR, whether that be this one or another.

@jordemort
Copy link
Contributor

I'm an old Perl 5 guy and haven't learned much of Perl 6 yet; #1173 seems farther along in general, but would someone with a more informed opinion than mine care to weigh in on the relative merits of this implementation of the pod62html script here vs the one in the other PR?

@Tyil
Copy link
Author

Tyil commented Dec 6, 2018

When I made this PR I missed the #1173, but that one was already stale at that point, so this got more attention for a bit, but now both PRs seem to be completely ignored by Github.

@kivikakk
Copy link
Contributor

Linguist PR has been merged, as has #1173, so will close this out now. We still have some work to do on our end before these will display on github.com.

@kivikakk kivikakk closed this Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub Pod Parsing
5 participants